From da708a9d67527054c45aa7cea08def4889a42632 Mon Sep 17 00:00:00 2001
From: Christian Heller <c.heller@plomlompom.de>
Date: Wed, 2 Apr 2025 13:58:49 +0200
Subject: [PATCH] Improve borgplom.

---
 testing/home/desktop/.local/bin/borgplom | 45 ++++++++++++++----------
 1 file changed, 26 insertions(+), 19 deletions(-)

diff --git a/testing/home/desktop/.local/bin/borgplom b/testing/home/desktop/.local/bin/borgplom
index f94d64b..40e0466 100755
--- a/testing/home/desktop/.local/bin/borgplom
+++ b/testing/home/desktop/.local/bin/borgplom
@@ -22,6 +22,8 @@ print_usage() {
     echo "  ${CMD_ORGPULL}   pull most recent org directory available in repos"
 }
 
+# exits
+
 error_exit() {
     echo "${PREFIX_ABORTING}$1"
     exit 1
@@ -33,39 +35,33 @@ error_exit_with_usage() {
     exit 1
 }
 
-check_args_beyond() {
-    _CMD="$1"
-    shift 1
-    if [ "$#" -gt 0 ]; then
-        _MSG="unexpected arguments beyond command '${_CMD}': $@"
-        error_exit "${_MSG}"
-    fi
-}
+# commands beyond print_usage
 
-_path_repo_location() {
-    echo "${PATH_BORG_CONF_SECURITY}/${1}/location"
-}
+_path_repo_location() { echo "${PATH_BORG_CONF_SECURITY}/${1}/location" }
 
 cmd_keys() {
     _PATH_CONF_KEYS="${PATH_BORG_CONF}/keys"
-    echo "Known keys as per ${PATH_BORG_CONF}:"
-    if [ ! -d "${_PATH_CONF_KEYS}" ]; then
-       echo "(none, since no ${_PATH_CONF_KEYS})"
+    _exit_ok() {
+       echo "(none, since directory ${1}."
        exit 0
+    }
+    echo "Known keys, as per ${_PATH_BORG_CONF_KEYS}:"
+    if [ ! -d "${_PATH_CONF_KEYS}" ]; then
+       exit_ok "non-existant"
     fi
     _KEYFILES="$(ls -1 ${_PATH_CONF_KEYS})"
     if [ -z "${_KEYFILES}" ]; then
-       echo "(none, directory empty)"
-       exit 0
+       exit_ok "empty"
     fi
     echo "${_KEYFILES}" | while read _FILENAME; do
         _KEY_ID=$(head -1 "${_PATH_CONF_KEYS}/${_FILENAME}" | cut -d' ' -f2)
-        _LOCATION=?
+        printf "${KEY_ID} ${_FILENAME} "
 	_PATH_LOC="$(cat $(_path_repo_location ${_KEY_ID}))"
         if [ -f "${_PATH_LOC}" ]; then
-            _LOCATION="$(cat ${_PATH_LOC})"
+            printf '%s\n' "$(cat ${_PATH_LOC})"
+        else
+            printf '?\n'
         fi
-	echo "${_KEY_ID} ${_FILENAME} ${_LOCATION}"
     done
 }
 
@@ -114,6 +110,17 @@ cmd_orgpull() {
     borg extract --verbose "${_REPO}::${_ARCHIVE}"
 }
 
+# parse args to execution
+
+check_args_beyond() {
+    _CMD="$1"
+    shift 1
+    if [ "$#" -gt 0 ]; then
+        _MSG="unexpected arguments beyond command '${_CMD}': $@"
+        error_exit "${_MSG}"
+    fi
+}
+
 if [ "$#" -lt 1 ]; then
     error_exit_with_usage "missing command."
 elif [ "$1" = "${CMD_HELP}" ]; then
-- 
2.30.2