From: Christian Heller <c.heller@plomlompom.de>
Date: Sun, 26 May 2013 03:59:35 +0000 (+0200)
Subject: Don't use variables for what's not variable.
X-Git-Tag: tce~1274
X-Git-Url: https://plomlompom.com/repos/%7B%7B%20web_path%20%7D%7D/decks/%7B%7Bdeck_id%7D%7D/bar%20baz.html?a=commitdiff_plain;h=1b2763d9c191be9e3917ca3c180d918ace19810b;p=plomrogue

Don't use variables for what's not variable.
---

diff --git a/roguelike.c b/roguelike.c
index c91c407..2952daf 100644
--- a/roguelike.c
+++ b/roguelike.c
@@ -10,12 +10,9 @@
 
 uint16_t rrand() {
 // Pseudo-random number generator (LGC algorithm). Use instead of rand() to ensure portable predictability.
-  uint32_t a   = 1103515245;      // Values for a and b as recommended by POSIX.1-2001 (see man page rand(3)).
-  uint16_t b   =      12345;
-  uint32_t mod = 2147483648;
   static uint32_t seed = 0;
-  seed = ((seed * a) + b) % mod;
-  return (seed / 65536); }        // Ignore least significant 16 bits (they are less random).
+  seed = ((seed * 1103515245) + 12345) % 2147483648;   // Values as recommended by POSIX.1-2001 (see rand(3)).
+  return (seed / 65536); }                         // Ignore least significant 16 bits (they are less random).
 
 void toggle_window (struct WinMeta * win_meta, struct Win * win) {
 // Toggle display of window win.