def _get_cached(cls: type[BaseModelInstance],
id_: BaseModelId) -> BaseModelInstance | None:
"""Get object of id_ from class's cache, or None if not found."""
- # pylint: disable=consider-iterating-dictionary
cache = cls.get_cache()
- if id_ in cache.keys():
+ if id_ in cache:
obj = cache[id_]
assert isinstance(obj, cls)
return obj
return obj
@classmethod
- def by_id(cls, db_conn: DatabaseConnection,
- id_: BaseModelId | None
- ) -> Self:
+ def by_id(cls, db_conn: DatabaseConnection, id_: BaseModelId) -> Self:
"""Retrieve by id_, on failure throw NotFoundException.
First try to get from cls.cache_, only then check DB; if found,
"""Wrapper around .by_id, creating (not caching/saving) if not find."""
if not cls.can_create_by_id:
raise HandledException('Class cannot .by_id_or_create.')
+ if id_ is None:
+ return cls(None)
try:
return cls.by_id(db_conn, id_)
except NotFoundException:
- obj = cls(id_)
- return obj
+ return cls(id_)
@classmethod
def all(cls: type[BaseModelInstance],