X-Git-Url: https://plomlompom.com/repos/%7B%7B%20web_path%20%7D%7D/decks/%7B%7Bdeck_id%7D%7D/cards/%7B%7Bcard_id%7D%7D/static/git-logo.png?a=blobdiff_plain;f=plomtask%2Fhttp.py;h=7c7fbd408edeb47dd48b9a4a04f93beca085f70a;hb=8f28c8c685fa91b9cbabb4b424da4091e52058cf;hp=be791599ff21868fc82ed7080dfefe6b1130e3fd;hpb=25b71c6f0b10db05907128daf50c6e543e514c35;p=plomtask diff --git a/plomtask/http.py b/plomtask/http.py index be79159..7c7fbd4 100644 --- a/plomtask/http.py +++ b/plomtask/http.py @@ -335,7 +335,8 @@ class TaskHandler(BaseHTTPRequestHandler): adoptables: dict[int, list[Todo]] = {} any_adoptables = [Todo.by_id(self.conn, t.id_) for t in Todo.by_date(self.conn, todo.date) - if t != todo] + if t.id_ is not None + and t != todo] for id_ in collect_adoptables_keys(steps_todo_to_process): adoptables[id_] = [t for t in any_adoptables if t.process.id_ == id_] @@ -410,13 +411,13 @@ class TaskHandler(BaseHTTPRequestHandler): def do_GET_condition_titles(self) -> dict[str, object]: """Show title history of Condition of ?id=.""" - id_ = self._params.get_int_or_none('id') + id_ = self._params.get_int('id') condition = Condition.by_id(self.conn, id_) return {'condition': condition} def do_GET_condition_descriptions(self) -> dict[str, object]: """Show description historys of Condition of ?id=.""" - id_ = self._params.get_int_or_none('id') + id_ = self._params.get_int('id') condition = Condition.by_id(self.conn, id_) return {'condition': condition} @@ -443,19 +444,19 @@ class TaskHandler(BaseHTTPRequestHandler): def do_GET_process_titles(self) -> dict[str, object]: """Show title history of Process of ?id=.""" - id_ = self._params.get_int_or_none('id') + id_ = self._params.get_int('id') process = Process.by_id(self.conn, id_) return {'process': process} def do_GET_process_descriptions(self) -> dict[str, object]: """Show description historys of Process of ?id=.""" - id_ = self._params.get_int_or_none('id') + id_ = self._params.get_int('id') process = Process.by_id(self.conn, id_) return {'process': process} def do_GET_process_efforts(self) -> dict[str, object]: """Show default effort history of Process of ?id=.""" - id_ = self._params.get_int_or_none('id') + id_ = self._params.get_int('id') process = Process.by_id(self.conn, id_) return {'process': process} @@ -597,6 +598,8 @@ class TaskHandler(BaseHTTPRequestHandler): # pylint: disable=too-many-branches id_ = self._params.get_int_or_none('id') for _ in self._form_data.get_all_str('delete'): + if id_ is None: + raise NotFoundException('trying to delete non-saved Process') process = Process.by_id(self.conn, id_) process.remove(self.conn) return '/processes' @@ -673,7 +676,9 @@ class TaskHandler(BaseHTTPRequestHandler): """Update/insert Condition of ?id= and fields defined in postvars.""" id_ = self._params.get_int_or_none('id') for _ in self._form_data.get_all_str('delete'): - condition = Condition.by_id(self.conn, id_) + if id_ is None: + raise NotFoundException('trying to delete non-saved Condition') + condition = Condition.by_id_or_create(self.conn, id_) condition.remove(self.conn) return '/conditions' condition = Condition.by_id_or_create(self.conn, id_)