From: Plom Heller Date: Thu, 30 Jul 2026 10:10:39 +0000 (+0200) Subject: Remove redundant code. X-Git-Url: https://plomlompom.com/repos/%7B%7Bdb.prefix%7D%7D/static/%22https:/validator.w3.org/task?a=commitdiff_plain;p=bricksplom Remove redundant code. --- diff --git a/bricksplom.py b/bricksplom.py index 7098deb..e6d4c77 100755 --- a/bricksplom.py +++ b/bricksplom.py @@ -657,22 +657,22 @@ class BricksDb: self, path_tables: str, path_ldraw: str, - ldraw_mode: str + ldraw_modes: str ) -> None: for name, cls in self.textfiled_tables().items(): kwargs = {'db': self} if issubclass(cls, WithDb) else {} setattr(self, name, cls.from_textfile((path_tables, f'{name}.txt'), **kwargs)) self._path_ldraw = Path(path_ldraw).joinpath('parts') - self._ldraw_mode = ldraw_mode.split(',') - if 'fill' in self._ldraw_mode: + self._ldraw_modes = ldraw_modes.split(',') + if 'fill' in self._ldraw_modes: for design in [design for design in self.designs.values() if not (design.alternate_to or design.ldraw)]: filename = f'{design.id_}.dat' if self._path_ldraw.joinpath(filename).exists(): assert design.direct_attrs is not None design.direct_attrs.ldraw = filename - self._check_consistencies(verify_ldraw='verify' in self._ldraw_mode) + self._check_consistencies() @classmethod def textfiled_tables( @@ -728,8 +728,7 @@ class BricksDb: return studs_counted def _check_consistencies( - self, - verify_ldraw=False + self ) -> None: fails = [] @@ -766,7 +765,7 @@ class BricksDb: if v != 0]: fails += [f'invalid count for brick of ID: {brick_id} ({count})'] - if verify_ldraw: + if 'verify' in self._ldraw_modes: for design in [ design for design in self.designs.values() if (not design.alternate_to)