"""Test Processes module."""
-from unittest import TestCase
from typing import Any
-from tests.utils import TestCaseWithDB, TestCaseWithServer
-from plomtask.processes import Process
-from plomtask.exceptions import NotFoundException, BadFormatException
+from tests.utils import (TestCaseSansDB, TestCaseWithDB, TestCaseWithServer,
+ Expected)
+from plomtask.processes import Process, ProcessStep
+from plomtask.conditions import Condition
+from plomtask.exceptions import NotFoundException
-class TestsSansDB(TestCase):
+class TestsSansDB(TestCaseSansDB):
"""Module tests not requiring DB setup."""
+ checked_class = Process
- def test_Process_versioned_defaults(self) -> None:
- """Test defaults of Process' VersionedAttributes."""
- self.assertEqual(Process(None).title.newest, 'UNNAMED')
- self.assertEqual(Process(None).description.newest, '')
- self.assertEqual(Process(None).effort.newest, 1.0)
- def test_Process_legal_ID(self) -> None:
- """Test Process cannot be instantiated with id_=0."""
- with self.assertRaises(BadFormatException):
- Process(0)
+class TestsSansDBProcessStep(TestCaseSansDB):
+ """Module tests not requiring DB setup."""
+ checked_class = ProcessStep
+ default_init_kwargs = {'owner_id': 2, 'step_process_id': 3,
+ 'parent_step_id': 4}
class TestsWithDB(TestCaseWithDB):
- """Mdule tests not requiring DB setup."""
+ """Module tests requiring DB setup."""
+ checked_class = Process
- def test_Process_ids(self) -> None:
- """Test Process.save_without_steps() re Process.id_."""
- p = Process(None)
- p.save_without_steps(self.db_conn)
- self.assertEqual(p.id_,
- Process.by_id(self.db_conn, 1, create=False).id_)
+ def three_processes(self) -> tuple[Process, Process, Process]:
+ """Return three saved processes."""
+ p1, p2, p3 = Process(None), Process(None), Process(None)
+ for p in [p1, p2, p3]:
+ p.save(self.db_conn)
+ return p1, p2, p3
+
+ def p_of_conditions(self) -> tuple[Process, list[Condition],
+ list[Condition], list[Condition]]:
+ """Return Process and its three Condition sets."""
p = Process(None)
- p.save_without_steps(self.db_conn)
- self.assertEqual(p.id_,
- Process.by_id(self.db_conn, 2, create=False).id_)
- p = Process(5)
- p.save_without_steps(self.db_conn)
- self.assertEqual(p.id_,
- Process.by_id(self.db_conn, 5, create=False).id_)
-
- def test_Process_versioned_attributes(self) -> None:
- """Test behavior of VersionedAttributes on saving (with .title)."""
+ c1, c2, c3 = Condition(None), Condition(None), Condition(None)
+ for c in [c1, c2, c3]:
+ c.save(self.db_conn)
+ assert isinstance(c1.id_, int)
+ assert isinstance(c2.id_, int)
+ assert isinstance(c3.id_, int)
+ set_1 = [c1, c2]
+ set_2 = [c2, c3]
+ set_3 = [c1, c3]
+ conds = [c.id_ for c in set_1 if isinstance(c.id_, int)]
+ enables = [c.id_ for c in set_2 if isinstance(c.id_, int)]
+ disables = [c.id_ for c in set_3 if isinstance(c.id_, int)]
+ p.set_condition_relations(self.db_conn, conds, [], enables, disables)
+ p.save(self.db_conn)
+ return p, set_1, set_2, set_3
+
+ def test_Process_conditions_saving(self) -> None:
+ """Test .save/.save_core."""
+ p, set1, set2, set3 = self.p_of_conditions()
+ assert p.id_ is not None
+ r = Process.by_id(self.db_conn, p.id_)
+ self.assertEqual(sorted(r.conditions), sorted(set1))
+ self.assertEqual(sorted(r.enables), sorted(set2))
+ self.assertEqual(sorted(r.disables), sorted(set3))
+
+ def test_from_table_row(self) -> None:
+ """Test .from_table_row() properly reads in class from DB."""
+ super().test_from_table_row()
+ p, set1, set2, set3 = self.p_of_conditions()
+ p.save(self.db_conn)
+ assert isinstance(p.id_, int)
+ for row in self.db_conn.row_where(self.checked_class.table_name,
+ 'id', p.id_):
+ r = Process.from_table_row(self.db_conn, row)
+ self.assertEqual(sorted(r.conditions), sorted(set1))
+ self.assertEqual(sorted(r.enables), sorted(set2))
+ self.assertEqual(sorted(r.disables), sorted(set3))
+
+ # def test_Process_steps(self) -> None:
+ # """Test addition, nesting, and non-recursion of ProcessSteps"""
+ # # pylint: disable=too-many-locals
+ # # pylint: disable=too-many-statements
+ # p1, p2, p3 = self.three_processes()
+ # assert isinstance(p1.id_, int)
+ # assert isinstance(p2.id_, int)
+ # assert isinstance(p3.id_, int)
+ # steps_p1: list[ProcessStep] = []
+ # # add step of process p2 as first (top-level) step to p1
+ # s_p2_to_p1 = ProcessStep(None, p1.id_, p2.id_, None)
+ # steps_p1 += [s_p2_to_p1]
+ # p1.set_steps(self.db_conn, steps_p1)
+ # p1_dict: dict[int, ProcessStepsNode] = {}
+ # p1_dict[1] = ProcessStepsNode(p2, None, True, {})
+ # self.assertEqual(p1.get_steps(self.db_conn, None), p1_dict)
+ # # add step of process p3 as second (top-level) step to p1
+ # s_p3_to_p1 = ProcessStep(None, p1.id_, p3.id_, None)
+ # steps_p1 += [s_p3_to_p1]
+ # p1.set_steps(self.db_conn, steps_p1)
+ # p1_dict[2] = ProcessStepsNode(p3, None, True, {})
+ # self.assertEqual(p1.get_steps(self.db_conn, None), p1_dict)
+ # # add step of process p3 as first (top-level) step to p2,
+ # steps_p2: list[ProcessStep] = []
+ # s_p3_to_p2 = ProcessStep(None, p2.id_, p3.id_, None)
+ # steps_p2 += [s_p3_to_p2]
+ # p2.set_steps(self.db_conn, steps_p2)
+ # # expect it as implicit sub-step of p1's second (p3) step
+ # p2_dict = {3: ProcessStepsNode(p3, None, False, {})}
+ # p1_dict[1].steps[3] = p2_dict[3]
+ # self.assertEqual(p1.get_steps(self.db_conn, None), p1_dict)
+ # # add step of process p2 as explicit sub-step to p1's second sub-step
+ # s_p2_to_p1_first = ProcessStep(None, p1.id_, p2.id_, s_p3_to_p1.id_)
+ # steps_p1 += [s_p2_to_p1_first]
+ # p1.set_steps(self.db_conn, steps_p1)
+ # seen_3 = ProcessStepsNode(p3, None, False, {}, False)
+ # p1_dict[1].steps[3].seen = True
+ # p1_dict[2].steps[4] = ProcessStepsNode(p2, s_p3_to_p1.id_, True,
+ # {3: seen_3})
+ # self.assertEqual(p1.get_steps(self.db_conn, None), p1_dict)
+ # # add step of process p3 as explicit sub-step to non-existing p1
+ # # sub-step (of id=999), expect it to become another p1 top-level step
+ # s_p3_to_p1_999 = ProcessStep(None, p1.id_, p3.id_, 999)
+ # steps_p1 += [s_p3_to_p1_999]
+ # p1.set_steps(self.db_conn, steps_p1)
+ # p1_dict[5] = ProcessStepsNode(p3, None, True, {})
+ # self.assertEqual(p1.get_steps(self.db_conn, None), p1_dict)
+ # # add step of process p3 as explicit sub-step to p1's implicit p3
+ # # sub-step, expect it to become another p1 top-level step
+ # s_p3_to_p1_impl_p3 = ProcessStep(None, p1.id_, p3.id_,
+ # s_p3_to_p2.id_)
+ # steps_p1 += [s_p3_to_p1_impl_p3]
+ # p1.set_steps(self.db_conn, steps_p1)
+ # p1_dict[6] = ProcessStepsNode(p3, None, True, {})
+ # self.assertEqual(p1.get_steps(self.db_conn, None), p1_dict)
+ # self.assertEqual(p1.used_as_step_by(self.db_conn), [])
+ # self.assertEqual(p2.used_as_step_by(self.db_conn), [p1])
+ # self.assertEqual(p3.used_as_step_by(self.db_conn), [p1, p2])
+ # # # add step of process p3 as explicit sub-step to p1's first
+ # # # sub-step, expect it to eliminate implicit p3 sub-step
+ # # s_p3_to_p1_first_explicit = ProcessStep(None, p1.id_, p3.id_,
+ # # s_p2_to_p1.id_)
+ # # p1_dict[1].steps = {7: ProcessStepsNode(p3, 1, True, {})}
+ # # p1_dict[2].steps[4].steps[3].seen = False
+ # # steps_p1 += [s_p3_to_p1_first_explicit]
+ # # p1.set_steps(self.db_conn, steps_p1)
+ # # self.assertEqual(p1.get_steps(self.db_conn, None), p1_dict)
+ # # ensure implicit steps non-top explicit steps are shown
+ # s_p3_to_p2_first = ProcessStep(None, p2.id_, p3.id_, s_p3_to_p2.id_)
+ # steps_p2 += [s_p3_to_p2_first]
+ # p2.set_steps(self.db_conn, steps_p2)
+ # p1_dict[1].steps[3].steps[7] = ProcessStepsNode(p3, 3, False, {},
+ # True)
+ # p1_dict[2].steps[4].steps[3].steps[7] = ProcessStepsNode(
+ # p3, 3, False, {}, False)
+ # self.assertEqual(p1.get_steps(self.db_conn, None), p1_dict)
+ # # ensure suppressed step nodes are hidden
+ # assert isinstance(s_p3_to_p2.id_, int)
+ # p1.set_step_suppressions(self.db_conn, [s_p3_to_p2.id_])
+ # p1_dict[1].steps[3].steps = {}
+ # p1_dict[1].steps[3].is_suppressed = True
+ # p1_dict[2].steps[4].steps[3].steps = {}
+ # p1_dict[2].steps[4].steps[3].is_suppressed = True
+ # self.assertEqual(p1.get_steps(self.db_conn), p1_dict)
+
+ def test_Process_conditions(self) -> None:
+ """Test setting Process.conditions/enables/disables."""
p = Process(None)
- p.save_without_steps(self.db_conn)
- p.title.set('named')
- p_loaded = Process.by_id(self.db_conn, p.id_)
- self.assertNotEqual(p.title.history, p_loaded.title.history)
- p.save_without_steps(self.db_conn)
- p_loaded = Process.by_id(self.db_conn, p.id_)
- self.assertEqual(p.title.history, p_loaded.title.history)
-
- def test_Process_steps(self) -> None:
- """Test addition, nesting, and non-recursion of ProcessSteps"""
- p_1 = Process(1)
- p_1.save_without_steps(self.db_conn)
- assert p_1.id_ is not None
- p_2 = Process(2)
- p_2.save_without_steps(self.db_conn)
- assert p_2.id_ is not None
- p_3 = Process(3)
- p_3.save_without_steps(self.db_conn)
- assert p_3.id_ is not None
- p_1.add_step(self.db_conn, None, p_2.id_, None)
- p_1_dict: dict[int, dict[str, Any]] = {1: {
- 'process': p_2, 'parent_id': None,
- 'is_explicit': True, 'steps': {}, 'seen': False
- }}
- self.assertEqual(p_1.get_steps(self.db_conn, None), p_1_dict)
- s_b = p_1.add_step(self.db_conn, None, p_3.id_, None)
- p_1_dict[2] = {
- 'process': p_3, 'parent_id': None,
- 'is_explicit': True, 'steps': {}, 'seen': False
- }
- self.assertEqual(p_1.get_steps(self.db_conn, None), p_1_dict)
- s_c = p_2.add_step(self.db_conn, None, p_3.id_, None)
- assert s_c.id_ is not None
- p_1_dict[1]['steps'] = {3: {
- 'process': p_3, 'parent_id': None,
- 'is_explicit': False, 'steps': {}, 'seen': False
- }}
- self.assertEqual(p_1.get_steps(self.db_conn, None), p_1_dict)
- p_1.add_step(self.db_conn, None, p_2.id_, s_b.id_)
- p_1_dict[2]['steps'][4] = {
- 'process': p_2, 'parent_id': s_b.id_, 'seen': False,
- 'is_explicit': True, 'steps': {3: {
- 'process': p_3, 'parent_id': None,
- 'is_explicit': False, 'steps': {}, 'seen': True
- }}}
- self.assertEqual(p_1.get_steps(self.db_conn, None), p_1_dict)
- p_1.add_step(self.db_conn, None, p_3.id_, 999)
- p_1_dict[5] = {
- 'process': p_3, 'parent_id': None,
- 'is_explicit': True, 'steps': {}, 'seen': False
- }
- self.assertEqual(p_1.get_steps(self.db_conn, None), p_1_dict)
- p_1.add_step(self.db_conn, None, p_3.id_, 3)
- p_1_dict[6] = {
- 'process': p_3, 'parent_id': None,
- 'is_explicit': True, 'steps': {}, 'seen': False
- }
- self.assertEqual(p_1.get_steps(self.db_conn, None), p_1_dict)
-
- def test_Process_by_id(self) -> None:
- """Test Process.by_id()."""
- with self.assertRaises(NotFoundException):
- Process.by_id(self.db_conn, None, create=False)
+ p.save(self.db_conn)
+ targets = ['conditions', 'blockers', 'enables', 'disables']
+ for i, target in enumerate(targets):
+ c1, c2 = Condition(None), Condition(None)
+ c1.save(self.db_conn)
+ c2.save(self.db_conn)
+ assert isinstance(c1.id_, int)
+ assert isinstance(c2.id_, int)
+ args: list[list[int]] = [[], [], [], []]
+ args[i] = []
+ p.set_condition_relations(self.db_conn, *args)
+ self.assertEqual(getattr(p, target), [])
+ args[i] = [c1.id_]
+ p.set_condition_relations(self.db_conn, *args)
+ self.assertEqual(getattr(p, target), [c1])
+ args[i] = [c2.id_]
+ p.set_condition_relations(self.db_conn, *args)
+ self.assertEqual(getattr(p, target), [c2])
+ args[i] = [c1.id_, c2.id_]
+ p.set_condition_relations(self.db_conn, *args)
+ self.assertEqual(getattr(p, target), [c1, c2])
+
+ def test_remove(self) -> None:
+ """Test removal of Processes and ProcessSteps."""
+ super().test_remove()
+ p1, p2, p3 = self.three_processes()
+ assert isinstance(p1.id_, int)
+ assert isinstance(p2.id_, int)
+ assert isinstance(p3.id_, int)
+ step = ProcessStep(None, p2.id_, p1.id_, None)
+ p2.set_steps(self.db_conn, [step])
+ step_id = step.id_
+ p2.set_steps(self.db_conn, [])
with self.assertRaises(NotFoundException):
- Process.by_id(self.db_conn, 0, create=False)
+ # check unset ProcessSteps actually cannot be found anymore
+ assert step_id is not None
+ ProcessStep.by_id(self.db_conn, step_id)
+ p1.remove(self.db_conn)
+ step = ProcessStep(None, p2.id_, p3.id_, None)
+ p2.set_steps(self.db_conn, [step])
+ step_id = step.id_
+ # check _can_ remove Process pointed to by ProcessStep.owner_id, and …
+ p2.remove(self.db_conn)
with self.assertRaises(NotFoundException):
- Process.by_id(self.db_conn, 1, create=False)
- self.assertNotEqual(Process(1).id_,
- Process.by_id(self.db_conn, None, create=True).id_)
- self.assertEqual(Process(1).id_,
- Process.by_id(self.db_conn, 1, create=True).id_)
- self.assertEqual(Process(2).id_,
- Process.by_id(self.db_conn, 2, create=True).id_)
-
- def test_Process_all(self) -> None:
- """Test Process.all()."""
- p_1 = Process(None)
- p_1.save_without_steps(self.db_conn)
- p_2 = Process(None)
- p_2.save_without_steps(self.db_conn)
- self.assertEqual({p_1.id_, p_2.id_},
- set(p.id_ for p in Process.all(self.db_conn)))
+ # … being dis-owned eliminates ProcessStep
+ assert step_id is not None
+ ProcessStep.by_id(self.db_conn, step_id)
+
+
+class TestsWithDBForProcessStep(TestCaseWithDB):
+ """Module tests requiring DB setup."""
+ checked_class = ProcessStep
+ default_init_kwargs = {'owner_id': 1, 'step_process_id': 2,
+ 'parent_step_id': 3}
+
+ def setUp(self) -> None:
+ super().setUp()
+ self.p1 = Process(1)
+ self.p1.save(self.db_conn)
+
+ def test_remove(self) -> None:
+ """Test .remove and unsetting of owner's .explicit_steps entry."""
+ p2 = Process(2)
+ p2.save(self.db_conn)
+ assert isinstance(self.p1.id_, int)
+ assert isinstance(p2.id_, int)
+ step = ProcessStep(None, self.p1.id_, p2.id_, None)
+ self.p1.set_steps(self.db_conn, [step])
+ step.remove(self.db_conn)
+ self.assertEqual(self.p1.explicit_steps, [])
+ self.check_identity_with_cache_and_db([])
+
+
+class ExpectedGetProcess(Expected):
+ """Builder of expectations for GET /processes."""
+ _default_dict = {'is_new': False, 'preset_top_step': None, 'n_todos': 0}
+ _on_empty_make_temp = ('Process', 'proc_as_dict')
+
+ def __init__(self,
+ proc_id: int,
+ *args: Any, **kwargs: Any) -> None:
+ self._fields = {'process': proc_id, 'steps': []}
+ super().__init__(*args, **kwargs)
+
+ @staticmethod
+ def stepnode_as_dict(step_id: int,
+ proc_id: int,
+ seen: bool = False,
+ steps: None | list[dict[str, object]] = None,
+ is_explicit: bool = True,
+ is_suppressed: bool = False) -> dict[str, object]:
+ # pylint: disable=too-many-arguments
+ """Return JSON of ProcessStepNode to expect."""
+ return {'step': step_id,
+ 'process': proc_id,
+ 'seen': seen,
+ 'steps': steps if steps else [],
+ 'is_explicit': is_explicit,
+ 'is_suppressed': is_suppressed}
+
+ def recalc(self) -> None:
+ """Update internal dictionary by subclass-specific rules."""
+ super().recalc()
+ self._fields['process_candidates'] = self.as_ids(
+ self.lib_all('Process'))
+ self._fields['condition_candidates'] = self.as_ids(
+ self.lib_all('Condition'))
+ self._fields['owners'] = [
+ s['owner_id'] for s in self.lib_all('ProcessStep')
+ if s['step_process_id'] == self._fields['process']]
+
+
+class ExpectedGetProcesses(Expected):
+ """Builder of expectations for GET /processes."""
+ _default_dict = {'sort_by': 'title', 'pattern': ''}
+
+ def recalc(self) -> None:
+ """Update internal dictionary by subclass-specific rules."""
+ super().recalc()
+ self._fields['processes'] = self.as_ids(self.lib_all('Process'))
class TestsWithServer(TestCaseWithServer):
"""Module tests against our HTTP server/handler (and database)."""
- def test_do_POST_process(self) -> None:
+ def _post_process(self, id_: int = 1,
+ form_data: dict[str, Any] | None = None
+ ) -> dict[str, Any]:
+ """POST basic Process."""
+ if not form_data:
+ form_data = {'title': 'foo', 'description': 'foo', 'effort': 1.1}
+ self.check_post(form_data, f'/process?id={id_}',
+ redir=f'/process?id={id_}')
+ return form_data
+
+ def test_fail_POST_process(self) -> None:
"""Test POST /process and its effect on the database."""
- self.assertEqual(0, len(Process.all(self.db_conn)))
- form_data = {'title': 'foo', 'description': 'foo', 'effort': 1.1}
- self.check_post(form_data, '/process?id=', 302, '/')
- self.assertEqual(1, len(Process.all(self.db_conn)))
- self.check_post(form_data, '/process?id=FOO', 400)
- form_data['effort'] = 'foo'
- self.check_post(form_data, '/process?id=', 400)
- self.check_post({}, '/process?id=', 400)
- form_data = {'title': '', 'description': ''}
- self.check_post(form_data, '/process?id=', 400)
- form_data = {'title': '', 'effort': 1.1}
- self.check_post(form_data, '/process?id=', 400)
- form_data = {'description': '', 'effort': 1.0}
- self.check_post(form_data, '/process?id=', 400)
- self.assertEqual(1, len(Process.all(self.db_conn)))
-
- def test_do_GET(self) -> None:
+ valid_post = {'title': '', 'description': '', 'effort': 1.0}
+ # check payloads lacking minimum expecteds
+ self.check_post({}, '/process', 400)
+ self.check_post({'title': '', 'description': ''}, '/process', 400)
+ self.check_post({'title': '', 'effort': 1}, '/process', 400)
+ self.check_post({'description': '', 'effort': 1}, '/process', 400)
+ # check payloads of bad data types
+ self.check_post(valid_post | {'effort': ''}, '/process', 400)
+ # check references to non-existant items
+ self.check_post(valid_post | {'conditions': [1]}, '/process', 404)
+ self.check_post(valid_post | {'disables': [1]}, '/process', 404)
+ self.check_post(valid_post | {'blockers': [1]}, '/process', 404)
+ self.check_post(valid_post | {'enables': [1]}, '/process', 404)
+ self.check_post(valid_post | {'new_top_step': 2}, '/process', 404)
+ # check deletion of non-existant
+ self.check_post({'delete': ''}, '/process?id=1', 404)
+
+ def test_basic_POST_process(self) -> None:
+ """Test basic GET/POST /process operations."""
+ # check on un-saved
+ exp = ExpectedGetProcess(1)
+ exp.force('process_candidates', [])
+ self.check_json_get('/process?id=1', exp)
+ # check on minimal payload post
+ valid_post = {'title': 'foo', 'description': 'oof', 'effort': 2.3}
+ exp.unforce('process_candidates')
+ self.post_exp_process([exp], valid_post, 1)
+ self.check_json_get('/process?id=1', exp)
+ # check n_todos field
+ self.post_exp_day([], {'new_todo': ['1']}, '2024-01-01')
+ self.post_exp_day([], {'new_todo': ['1']}, '2024-01-02')
+ exp.set('n_todos', 2)
+ self.check_json_get('/process?id=1', exp)
+ # check cannot delete if Todos to Process
+ self.check_post({'delete': ''}, '/process?id=1', 500)
+ # check cannot delete if some ProcessStep's .step_process_id
+ self.post_exp_process([exp], valid_post, 2)
+ self.post_exp_process([exp], valid_post | {'new_top_step': 2}, 3)
+ self.check_post({'delete': ''}, '/process?id=2', 500)
+ # check successful deletion
+ self.post_exp_process([exp], valid_post, 4)
+ self.check_post({'delete': ''}, '/process?id=4', 302, '/processes')
+ exp = ExpectedGetProcess(4)
+ exp.set_proc_from_post(1, valid_post)
+ exp.set_proc_from_post(2, valid_post)
+ exp.set_proc_from_post(3, valid_post)
+ exp.lib_set('ProcessStep', [exp.procstep_as_dict(1, 3, 2)])
+ exp.force('process_candidates', [1, 2, 3])
+ self.check_json_get('/process?id=4', exp)
+
+ def test_POST_process_steps(self) -> None:
+ """Test behavior of ProcessStep posting."""
+ # pylint: disable=too-many-statements
+ url = '/process?id=1'
+ exp = ExpectedGetProcess(1)
+ self.post_exp_process([exp], {}, 1)
+ # post first (top-level) step of proc 2 to proc 1 by 'step_of' in 2
+ self.post_exp_process([exp], {'step_of': 1}, 2)
+ exp.lib_set('ProcessStep', [exp.procstep_as_dict(1, 1, 2)])
+ exp.set('steps', [exp.stepnode_as_dict(1, 2)])
+ self.check_json_get(url, exp)
+ # post empty/absent steps list to process, expect clean slate, and old
+ # step to completely disappear
+ self.post_exp_process([exp], {}, 1)
+ exp.lib_wipe('ProcessStep')
+ exp.set('steps', [])
+ self.check_json_get(url, exp)
+ # post new step of proc2 to proc1 by 'new_top_step'
+ self.post_exp_process([exp], {'new_top_step': 2}, 1)
+ exp.lib_set('ProcessStep', [exp.procstep_as_dict(1, 1, 2)])
+ self.post_exp_process([exp], {'kept_steps': [1]}, 1)
+ exp.set('steps', [exp.stepnode_as_dict(1, 2)])
+ self.check_json_get(url, exp)
+ # fail on single- and multi-step recursion
+ p_min = {'title': '', 'description': '', 'effort': 0}
+ self.check_post(p_min | {'new_top_step': 1}, url, 400)
+ self.check_post(p_min | {'step_of': 1}, url, 400)
+ self.post_exp_process([exp], {'new_top_step': 1}, 2)
+ self.check_post(p_min | {'step_of': 2, 'new_top_step': 2}, url, 400)
+ self.post_exp_process([exp], {}, 3)
+ self.post_exp_process([exp], {'step_of': 3}, 4)
+ self.check_post(p_min | {'new_top_step': 3, 'step_of': 4}, url, 400)
+ # post sibling steps
+ self.post_exp_process([exp], {}, 4)
+ self.post_exp_process([exp], {'new_top_step': 4}, 1)
+ self.post_exp_process([exp], {'kept_steps': [1], 'new_top_step': 4}, 1)
+ exp.lib_set('ProcessStep', [exp.procstep_as_dict(1, 1, 4),
+ exp.procstep_as_dict(2, 1, 4)])
+ exp.set('steps', [exp.stepnode_as_dict(1, 4),
+ exp.stepnode_as_dict(2, 4)])
+ self.check_json_get(url, exp)
+ # post sub-step chain
+ p = {'kept_steps': [1, 2], 'new_step_to_2': 4}
+ self.post_exp_process([exp], p, 1)
+ exp.lib_set('ProcessStep', [exp.procstep_as_dict(3, 1, 4, 2)])
+ exp.set('steps', [exp.stepnode_as_dict(1, 4),
+ exp.stepnode_as_dict(2, 4, steps=[
+ exp.stepnode_as_dict(3, 4)])])
+ self.check_json_get(url, exp)
+ # fail posting sub-step that would cause recursion
+ self.post_exp_process([exp], {}, 6)
+ self.post_exp_process([exp], {'new_top_step': 6}, 5)
+ p = p_min | {'kept_steps': [1, 2, 3], 'new_step_to_2': 5, 'step_of': 6}
+ self.check_post(p, url, 400)
+
+ def test_GET(self) -> None:
"""Test /process and /processes response codes."""
self.check_get('/process', 200)
self.check_get('/process?id=', 200)
- self.check_get('/process?id=0', 400)
- self.check_get('/process?id=FOO', 400)
+ self.check_get('/process?id=1', 200)
+ self.check_get_defaults('/process')
self.check_get('/processes', 200)
+
+ def test_fail_GET_process(self) -> None:
+ """Test invalid GET /process params."""
+ # check for invalid IDs
+ self.check_get('/process?id=foo', 400)
+ self.check_get('/process?id=0', 500)
+ # check we catch invalid base64
+ self.check_get('/process?title_b64=foo', 400)
+ # check failure on references to unknown processes; we create Process
+ # of ID=1 here so we know the 404 comes from step_to=2 etc. (that tie
+ # the Process displayed by /process to others), not from not finding
+ # the main Process itself
+ self.post_exp_process([], {}, 1)
+ self.check_get('/process?id=1&step_to=2', 404)
+ self.check_get('/process?id=1&has_step=2', 404)
+
+ def test_GET_processes(self) -> None:
+ """Test GET /processes."""
+ # pylint: disable=too-many-statements
+ # test empty result on empty DB, default-settings on empty params
+ exp = ExpectedGetProcesses()
+ self.check_json_get('/processes', exp)
+ # test on meaningless non-empty params (incl. entirely un-used key),
+ # that 'sort_by' default to 'title' (even if set to something else, as
+ # long as without handler) and 'pattern' get preserved
+ exp.set('pattern', 'bar') # preserved despite zero effect!
+ url = '/processes?sort_by=foo&pattern=bar&foo=x'
+ self.check_json_get(url, exp)
+ # test non-empty result, automatic (positive) sorting by title
+ proc1_post = {'title': 'foo', 'description': 'oof', 'effort': 1.0}
+ self.post_exp_process([exp], proc1_post, 1)
+ proc2_post = {'title': 'bar', 'description': 'rab', 'effort': 1.1}
+ self.post_exp_process([exp], proc2_post | {'new_top_step': [1]}, 2)
+ proc3_post = {'title': 'baz', 'description': 'zab', 'effort': 0.9}
+ self.post_exp_process([exp], proc3_post | {'new_top_step': [1]}, 3)
+ proc3_post = proc3_post | {'new_top_step': [2], 'kept_steps': [2]}
+ self.post_exp_process([exp], proc3_post, 3)
+ exp.lib_set('ProcessStep', [exp.procstep_as_dict(1, 2, 1),
+ exp.procstep_as_dict(2, 3, 1),
+ exp.procstep_as_dict(3, 3, 2)])
+ exp.lib_get('Process', '')
+ exp.set('pattern', '')
+ exp.force('processes', [2, 3, 1])
+ self.check_json_get('/processes', exp)
+ # test other sortings
+ exp.set('sort_by', '-title')
+ exp.force('processes', [1, 3, 2])
+ self.check_json_get('/processes?sort_by=-title', exp)
+ exp.set('sort_by', 'effort')
+ exp.force('processes', [3, 1, 2])
+ self.check_json_get('/processes?sort_by=effort', exp)
+ exp.set('sort_by', '-effort')
+ exp.force('processes', [2, 1, 3])
+ self.check_json_get('/processes?sort_by=-effort', exp)
+ exp.set('sort_by', 'steps')
+ exp.force('processes', [1, 2, 3])
+ self.check_json_get('/processes?sort_by=steps', exp)
+ exp.set('sort_by', '-steps')
+ exp.force('processes', [3, 2, 1])
+ self.check_json_get('/processes?sort_by=-steps', exp)
+ exp.set('sort_by', 'owners')
+ exp.force('processes', [3, 2, 1])
+ self.check_json_get('/processes?sort_by=owners', exp)
+ exp.set('sort_by', '-owners')
+ exp.force('processes', [1, 2, 3])
+ self.check_json_get('/processes?sort_by=-owners', exp)
+ # test pattern matching on title
+ exp.set('pattern', 'ba')
+ exp.set('sort_by', 'title')
+ exp.lib_del('Process', '1')
+ exp.force('processes', [2, 3])
+ self.check_json_get('/processes?pattern=ba', exp)
+ # test pattern matching on description
+ exp.set('pattern', 'of')
+ exp.lib_wipe('Process')
+ exp.lib_wipe('ProcessStep')
+ self.post_exp_process([exp], {'description': 'oof', 'effort': 1.0}, 1)
+ exp.force('processes', [1])
+ self.check_json_get('/processes?pattern=of', exp)
projects / plomtask / blobdiff
![[plomtask]](/repos/%7B%7Bdb.prefix%7D%7D/static/git-favicon.png?p=plomtask;a=tree;hb=HEAD){kind=link}
