From bb15ac1c0bd45f902c05645ddb4ebea52337c125 Mon Sep 17 00:00:00 2001
From: Christian Heller <c.heller@plomlompom.de>
Date: Sun, 27 Apr 2025 18:31:19 +0200
Subject: [PATCH] Renamed class for more clarity.

---
 src/templates/_base.tmpl             |  4 ++--
 src/templates/_macros.tmpl           | 14 +++++++-------
 src/templates/balance.tmpl           |  2 +-
 src/templates/edit_structured.tmpl   |  6 +++---
 src/templates/ledger_raw.tmpl        |  2 +-
 src/templates/ledger_structured.tmpl |  8 ++++----
 6 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/src/templates/_base.tmpl b/src/templates/_base.tmpl
index 268e586..0dc07b1 100644
--- a/src/templates/_base.tmpl
+++ b/src/templates/_base.tmpl
@@ -34,7 +34,7 @@ table.alternating > tbody > tr:nth-child(even) {
 td {
     vertical-align: top;
 }
-div.bad, td.bad, tr.bad, span.bad {
+div.critical, td.critical, tr.critical, span.critical, input[type="submit"].critical {
     {{macros.css_bg_red()}}
 }
 {% block css %}{% endblock %}
@@ -50,7 +50,7 @@ ledger <a href="/ledger_structured">structured</a>
 · <a href="/balance">balance</a>
 ·
 {% if tainted %}
-    <span class="bad">unsaved changes:
+    <span class="critical">unsaved changes:
 {% endif %}
 <input type="submit"name="file_load" value="reload" />
 {% if tainted %}
diff --git a/src/templates/_macros.tmpl b/src/templates/_macros.tmpl
index 05dc359..7d6b9c4 100644
--- a/src/templates/_macros.tmpl
+++ b/src/templates/_macros.tmpl
@@ -24,10 +24,10 @@ td.amount, td.currency {
 
 
 {% macro css_balance() %}
-table.alternating.bad > tbody > tr:nth-child(odd) {
+table.alternating.critical > tbody > tr:nth-child(odd) {
     {{ css_bg_red() }}
 }
-table.alternating.bad > tbody > tr:nth-child(even) {
+table.alternating.critical > tbody > tr:nth-child(even) {
     background-color: #ff8a8a;
 }
 td.balance.amount {
@@ -63,7 +63,7 @@ td.balance.currency {
 td.block_column {
     {{css_bg_white()}}
 }
-td.block_column.bad {
+td.block_column.critical {
     {{css_bg_red()}}
 }
 {% endmacro %}
@@ -73,12 +73,12 @@ td.block_column.bad {
 {% macro ledger_block_columns(mode, block) %}
 <tr></tr><!-- just to keep the background-color alternation in proper order -->
 <tr id="block_{{block.id_}}">
-<td class="block_column {% if block.date_error %}bad{% endif %}" rowspan={{block.lines|length + 1}}>
+<td class="block_column {% if block.date_error %}critical{% endif %}" rowspan={{block.lines|length + 1}}>
 <input type="submit" name="ledger_moveup_{{block.id_}}" value="^" {% if not block.can_move(1) %}disabled{% endif %}/><br />
 <input type="submit" name="ledger_movedown_{{block.id_}}" value="v" {% if not block.can_move(0) %}disabled{% endif %}/><br />
 <input type="submit" name="ledger_copy_{{block.id_}}" value="C" />
 </td>
-<td class="block_column {% if block.booking and block.booking.sink_error %}bad{% endif %}" rowspan={{block.lines|length + 1}}>
+<td class="block_column {% if block.booking and block.booking.sink_error %}critical{% endif %}" rowspan={{block.lines|length + 1}}>
 [<a href="#block_{{block.id_}}">#</a>]<br />
 [<a href="/balance?up_incl={{block.id_}}">b</a>]<br />
 [<a href="/edit_{{mode}}/{{block.id_}}">e</a>]
@@ -159,7 +159,7 @@ function taint() {
 </span>
 <hr />
 {% if block.date_error or (block.booking and block.booking.sink_error) %}
-    <div class="bad">block-wide errors:
+    <div class="critical">block-wide errors:
     {{block.date_error}}
     {% if block.booking %}
         {% if block.date_error %}– and:{% endif %}
@@ -198,7 +198,7 @@ function taint() {
         {{ booking_balance_account_with_children(child) }}
     {% endfor %}
 {% endmacro %}
-<table class="alternating {% if not valid %}bad{% endif %}">
+<table class="alternating {% if not valid %}critical{% endif %}">
 <tr>
 <th>account</th>
 <th>before</th>
diff --git a/src/templates/balance.tmpl b/src/templates/balance.tmpl
index 4f8533c..630bfbf 100644
--- a/src/templates/balance.tmpl
+++ b/src/templates/balance.tmpl
@@ -92,7 +92,7 @@ span.indent {
 |
 balance after <a href="/blocks/{{block.id_}}">booking {{block.id_}} ({{block.booking.date}}: {{block.booking.target}})</a>
 </p>
-<table class="alternating {% if not valid %}bad{% endif %}">
+<table class="alternating {% if not valid %}critical{% endif %}">
 {% for root in roots %}
     {{account_with_children(block.id_,root,indent=0)}}
 {% endfor %}
diff --git a/src/templates/edit_structured.tmpl b/src/templates/edit_structured.tmpl
index ec677e4..dca7e0a 100644
--- a/src/templates/edit_structured.tmpl
+++ b/src/templates/edit_structured.tmpl
@@ -89,7 +89,7 @@ function update_form() {
         function setup_input_td(tr, colspan) {
             const td = add_td(tr, colspan);
             if (booking_line.errors.length > 0) {
-                td.classList.add('bad');
+                td.classList.add('critical');
             };
             return td;
         }
@@ -158,14 +158,14 @@ function update_form() {
 
         // add error explanation row if necessary
         if (booking_line.errors.length > 0) {
-            tr.classList.add('bad');
+            tr.classList.add('critical');
             const tr_info = document.createElement('tr');
             tr_info.classList.add('skip');
             table.appendChild(tr_info);
             const td = add_td(tr_info, 7);
             tr.appendChild(document.createElement('td'));
             td.textContent = 'line bad:' + booking_line.errors;
-            tr_info.classList.add('bad');
+            tr_info.classList.add('critical');
         }
     }
 }
diff --git a/src/templates/ledger_raw.tmpl b/src/templates/ledger_raw.tmpl
index 3bc1b39..76a3298 100644
--- a/src/templates/ledger_raw.tmpl
+++ b/src/templates/ledger_raw.tmpl
@@ -18,7 +18,7 @@ table {
     {{macros.ledger_block_columns('raw', block)}}
     {% for line in block.lines %}
         <tr>
-        <td {% if line.errors %}class="bad"{% endif %}>{{line.raw}}&nbsp;</td>
+        <td {% if line.errors %}class="critical"{% endif %}>{{line.raw}}&nbsp;</td>
         </tr>
     {% endfor %}
 {% endfor %}
diff --git a/src/templates/ledger_structured.tmpl b/src/templates/ledger_structured.tmpl
index 1838c34..12b7400 100644
--- a/src/templates/ledger_structured.tmpl
+++ b/src/templates/ledger_structured.tmpl
@@ -22,14 +22,14 @@ td.amount, td.currency {
     {{macros.ledger_block_columns('structured', block)}}
     {% if block.booking %}
         <tr>
-        <td colspan=3 {% if block.booking.intro_line.errors %}class="bad"{% endif %}>{{block.booking.date}} {{block.booking.target}}</td>
+        <td colspan=3 {% if block.booking.intro_line.errors %}class="critical"{% endif %}>{{block.booking.date}} {{block.booking.target}}</td>
         <td>{{block.booking.intro_line.comment}}</td>
         </tr>
         {% for line in block.booking.transfer_lines %}
             <tr>
-            <td class="amount {% if line.errors %}bad{% endif %}">{{line.amount_short}}</td>
-            <td class="currency {% if line.errors %}bad{% endif %}">{{ macros.currency_short(line.currency) }}</td>
-            <td {% if line.errors %}class="bad"{% endif %}>{{line.account}}</td>
+            <td class="amount {% if line.errors %}critical{% endif %}">{{line.amount_short}}</td>
+            <td class="currency {% if line.errors %}critical{% endif %}">{{ macros.currency_short(line.currency) }}</td>
+            <td {% if line.errors %}class="critical"{% endif %}>{{line.account}}</td>
             <td>{{line.comment}}</td>
             </tr>
         {% endfor %}
-- 
2.30.2