Server: Make code in build_fov_map() slightly less bizarre.

[plomrogue] / src / server / field_of_view.c

diff --git a/src/server/field_of_view.c b/src/server/field_of_view.c
index b653e3a373ee41b2af759e5476baf60fad7b4584..86eab2a3419ec52aae9257736b3126fb63a94375 100644 (file)
--- a/src/server/field_of_view.c
+++ b/src/server/field_of_view.c
@@ -1,7 +1,8 @@
 /* src/server/field_of_view.c */
 
 #include "field_of_view.h"
-#include <stdint.h> /* uint8_t, uint16_t, uint32_t, int32_t */
+#include <stddef.h> /* NULL */
+#include <stdint.h> /* uint8_t, uint16_t, uint32_t, int32_t, UINT8_MAX */
 #include <stdlib.h> /* free() */
 #include <string.h> /* memset() */
 #include "../common/rexit.h" /* exit_trouble() */
@@ -323,26 +324,25 @@ extern void build_fov_map(struct Thing * t)
     for (circle_i = 1, circle_is_on_map = 1; circle_is_on_map; circle_i++)
     {
         circle_is_on_map = 0;
-        if (1 != circle_i)
-        {
-            mv_yx_in_dir_legal('c', &test_pos);
-        }
-        char dir_char = 'd';
-        uint8_t dir_char_pos_in_circledirs_string = 0;
+        if (1 < circle_i)                      /* All circles but the 1st are */
+        {                                      /* moved into starting from a  */
+            mv_yx_in_dir_legal('c', &test_pos);/* previous circle's last hex, */
+        }                                      /* i.e. from the upper left.   */
+        char dir_char = 'd'; /* Circle's 1st hex is entered by rightward move.*/
+        uint8_t dir_char_pos_in_circledirs_string = UINT8_MAX;
         uint16_t dist_i, hex_i;
-        for (hex_i = 0, dist_i = 1; hex_i < 6 * circle_i; dist_i++, hex_i++)
+        for (hex_i=0, dist_i=circle_i; hex_i < 6 * circle_i; dist_i++, hex_i++)
         {
+            if (circle_i < dist_i)
+            {
+                dist_i = 1;
+                dir_char=circledirs_string[++dir_char_pos_in_circledirs_string];
+            }
             if (mv_yx_in_dir_legal(dir_char, &test_pos))
             {
                 eval_position(circle_i, hex_i, t->fov_map, &test_pos, &shadows);
                 circle_is_on_map = 1;
             }
-            dir_char = circledirs_string[dir_char_pos_in_circledirs_string];
-            if (circle_i == dist_i)
-            {
-                dist_i = 0;
-                dir_char_pos_in_circledirs_string++;
-            }
         }
     }
     mv_yx_in_dir_legal(0, NULL);