home
·
contact
·
privacy
projects
/
plomrogue
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Remove redundant uses of NULL.
[plomrogue]
/
src
/
server
/
thing_actions.c
diff --git
a/src/server/thing_actions.c
b/src/server/thing_actions.c
index e91f576aa3ebfd5ed84fbb296c2ba100f0f4d574..ec713ae5bd02dc2e9dac915c48066e154812b151 100644
(file)
--- a/
src/server/thing_actions.c
+++ b/
src/server/thing_actions.c
@@
-85,7
+85,6
@@
static uint8_t text_equals_log_end(char * log, char * text)
static void update_log(char * text)
{
static void update_log(char * text)
{
- char * f_name = "update_log()";
uint16_t len_new = strlen(text);
uint16_t len_old = 0;
uint16_t offset = 0;
uint16_t len_new = strlen(text);
uint16_t len_old = 0;
uint16_t offset = 0;
@@
-103,10
+102,10
@@
static void update_log(char * text)
}
}
uint16_t len_whole = len_old + len_new + 1;
}
}
uint16_t len_whole = len_old + len_new + 1;
- char * new_text = try_malloc(len_whole,
f_name
);
+ char * new_text = try_malloc(len_whole,
__func__
);
memcpy(new_text, world.log + offset, len_old);
int test = sprintf(new_text + len_old, "%s", text);
memcpy(new_text, world.log + offset, len_old);
int test = sprintf(new_text + len_old, "%s", text);
- exit_trouble(test < 0,
f_name
, s[S_FCN_SPRINTF]);
+ exit_trouble(test < 0,
__func__
, s[S_FCN_SPRINTF]);
free(world.log);
world.log = new_text;
}
free(world.log);
world.log = new_text;
}
@@
-115,7
+114,6
@@
static void update_log(char * text)
static void actor_hits_actor(struct Thing * hitter, struct Thing * hitted)
{
static void actor_hits_actor(struct Thing * hitter, struct Thing * hitted)
{
- char * f_name = "actor_hits_actor()";
struct ThingType * tt_hitter = get_thing_type(hitter->type);
struct ThingType * tt_hitted = get_thing_type(hitted->type);
struct Thing * player = get_player();
struct ThingType * tt_hitter = get_thing_type(hitter->type);
struct ThingType * tt_hitted = get_thing_type(hitted->type);
struct Thing * player = get_player();
@@
-132,9
+130,9
@@
static void actor_hits_actor(struct Thing * hitter, struct Thing * hitted)
msg3 = tt_hitted->name;
}
uint8_t len = 1 + strlen(msg1) + 1 + strlen(msg2) + 1 + strlen(msg3) + 2;
msg3 = tt_hitted->name;
}
uint8_t len = 1 + strlen(msg1) + 1 + strlen(msg2) + 1 + strlen(msg3) + 2;
- char * msg = try_malloc(len,
f_name
);
+ char * msg = try_malloc(len,
__func__
);
int test = sprintf(msg, "\n%s %s %s.", msg1, msg2, msg3);
int test = sprintf(msg, "\n%s %s %s.", msg1, msg2, msg3);
- exit_trouble(test < 0,
f_name
, s[S_FCN_SPRINTF]);
+ exit_trouble(test < 0,
__func__
, s[S_FCN_SPRINTF]);
update_log(msg);
free(msg);
hitted->lifepoints--;
update_log(msg);
free(msg);
hitted->lifepoints--;
@@
-144,8
+142,16
@@
static void actor_hits_actor(struct Thing * hitter, struct Thing * hitted)
if (player == hitted)
{
update_log(" You die.");
if (player == hitted)
{
update_log(" You die.");
+ memset(hitted->fov_map, ' ', world.map.length * world.map.length);
return;
}
return;
}
+ else
+ {
+ free(hitted->fov_map);
+ hitted->fov_map = NULL;
+ free(hitted->mem_map);
+ hitted->mem_map = NULL;
+ }
update_log(" It dies.");
}
}
update_log(" It dies.");
}
}
@@
-173,7
+179,6
@@
static uint8_t match_dir(char d, char ** dsc_d, char match, char * dsc_match)
static void playerbonus_move(char d, uint8_t passable)
{
static void playerbonus_move(char d, uint8_t passable)
{
- char * f_name = "playerbonus_move()";
char * dsc_dir = "north-east";
if ( match_dir(d, &dsc_dir, 'd', "east")
|| match_dir(d, &dsc_dir, 'c', "south-east")
char * dsc_dir = "north-east";
if ( match_dir(d, &dsc_dir, 'd', "east")
|| match_dir(d, &dsc_dir, 'c', "south-east")
@@
-188,9
+193,9
@@
static void playerbonus_move(char d, uint8_t passable)
{
dsc_move = "You fail to move ";
}
{
dsc_move = "You fail to move ";
}
- char * msg = try_malloc(strlen(dsc_move) + strlen (dsc_dir) + 3,
f_name
);
+ char * msg = try_malloc(strlen(dsc_move) + strlen (dsc_dir) + 3,
__func__
);
int test = sprintf(msg, "\n%s%s.", dsc_move, dsc_dir);
int test = sprintf(msg, "\n%s%s.", dsc_move, dsc_dir);
- exit_trouble(test < 0,
f_name
, s[S_FCN_SPRINTF]);
+ exit_trouble(test < 0,
__func__
, s[S_FCN_SPRINTF]);
update_log(msg);
free(msg);
}
update_log(msg);
free(msg);
}
@@
-269,8
+274,7
@@
extern void actor_move(struct Thing * t)
if (passable)
{
set_thing_position(t, target);
if (passable)
{
set_thing_position(t, target);
- free(t->fov_map);
- t->fov_map = build_fov_map(t);
+ build_fov_map(t);
}
if (t == get_player())
{
}
if (t == get_player())
{
@@
-282,7
+286,7
@@
extern void actor_move(struct Thing * t)
extern void actor_drop(struct Thing * t)
{
extern void actor_drop(struct Thing * t)
{
- uint8_t owns_none = (
NULL ==
t->owns);
+ uint8_t owns_none = (
!
t->owns);
if (!owns_none)
{
uint8_t select = t->arg;
if (!owns_none)
{
uint8_t select = t->arg;
@@
-303,21
+307,21
@@
extern void actor_pick(struct Thing * t)
{
struct Thing * picked = NULL;
struct Thing * t_i;
{
struct Thing * picked = NULL;
struct Thing * t_i;
- for (t_i = world.things;
NULL !=
t_i; t_i = t_i->next)
+ for (t_i = world.things; t_i; t_i = t_i->next)
{
if (t_i != t && yx_uint8_cmp(&t_i->pos, &t->pos))
{
picked = t_i;
}
}
{
if (t_i != t && yx_uint8_cmp(&t_i->pos, &t->pos))
{
picked = t_i;
}
}
- if (
NULL !=
picked)
+ if (picked)
{
own_thing(&t->owns, &world.things, picked->id);
set_thing_position(picked, t->pos);
}
if (t == get_player())
{
{
own_thing(&t->owns, &world.things, picked->id);
set_thing_position(picked, t->pos);
}
if (t == get_player())
{
- playerbonus_pick(
NULL != picked
);
+ playerbonus_pick(
!(!picked)
);
}
}
}
}
@@
-326,7
+330,7
@@
extern void actor_pick(struct Thing * t)
extern void actor_use(struct Thing * t)
{
uint8_t wrong_thing = 1;
extern void actor_use(struct Thing * t)
{
uint8_t wrong_thing = 1;
- uint8_t no_thing = (
NULL ==
t->owns);
+ uint8_t no_thing = (
!
t->owns);
if (!no_thing)
{
uint8_t select = t->arg;
if (!no_thing)
{
uint8_t select = t->arg;