Split BaseModel.by_id into .by_id and by_id_or_create, refactor tests.

[plomtask] / plomtask / days.py

diff --git a/plomtask/days.py b/plomtask/days.py
index a924bbfeadd2bd895d2f21ac4b7487305fbe771f..267156d831583d591788ad5a79bb6eb0013bdeaa 100644 (file)
--- a/plomtask/days.py
+++ b/plomtask/days.py
@@ -12,6 +12,7 @@ class Day(BaseModel[str]):
     """Individual days defined by their dates."""
     table_name = 'days'
     to_save = ['comment']
+    can_create_by_id = True
 
     def __init__(self, date: str, comment: str = '') -> None:
         id_ = valid_date(date)
@@ -40,12 +41,9 @@ class Day(BaseModel[str]):
         return day
 
     @classmethod
-    def by_id(cls,
-              db_conn: DatabaseConnection, id_: str | None,
-              create: bool = False,
-              ) -> Day:
+    def by_id(cls, db_conn: DatabaseConnection, id_: str | None) -> Day:
         """Extend BaseModel.by_id checking for new/lost .todos."""
-        day = super().by_id(db_conn, id_, create)
+        day = super().by_id(db_conn, id_)
         assert day.id_ is not None
         if day.id_ in Todo.days_to_update:
             Todo.days_to_update.remove(day.id_)