Refactor updates of relations tables.

[plomtask] / plomtask / db.py

diff --git a/plomtask/db.py b/plomtask/db.py
index abd8f6181db946b357902a0ec851f51919f37344..bf633e2c9826f464c690b03b75dfda4a33df7234 100644 (file)
--- a/plomtask/db.py
+++ b/plomtask/db.py
@@ -67,6 +67,20 @@ class DatabaseConnection:
         """Close DB connection."""
         self.conn.close()
 
+    def rewrite_relations(self, table_name: str, key: str, target: int,
+                          rows: list[list[Any]]) -> None:
+        """Rewrite relations in table_name to target, with rows values."""
+        self.exec(f'DELETE FROM {table_name} WHERE {key} = ?', (target,))
+        for row in rows:
+            values = tuple([target] + row)
+            q_marks = self.__class__.q_marks_from_values(values)
+            self.exec(f'INSERT INTO {table_name} VALUES {q_marks}', values)
+
+    @staticmethod
+    def q_marks_from_values(values: tuple[Any]) -> str:
+        """Return placeholder to insert values into SQL code."""
+        return '(' + ','.join(['?'] * len(values)) + ')'
+
 
 class BaseModel:
     """Template for most of the models we use/derive from the DB."""
@@ -114,11 +128,11 @@ class BaseModel:
     def save_core(self, db_conn: DatabaseConnection,
                   update_with_lastrowid: bool = True) -> None:
         """Write bare-bones self (sans connected items), ensuring self.id_."""
-        q_marks = ','.join(['?'] * (len(self.to_save) + 1))
         values = tuple([self.id_] + [getattr(self, key)
                                      for key in self.to_save])
+        q_marks = DatabaseConnection.q_marks_from_values(values)
         table_name = self.table_name
-        cursor = db_conn.exec(f'REPLACE INTO {table_name} VALUES ({q_marks})',
+        cursor = db_conn.exec(f'REPLACE INTO {table_name} VALUES {q_marks}',
                               values)
         if update_with_lastrowid:
             self.id_ = cursor.lastrowid