Fix buggy Todo saving/removing.

[plomtask] / plomtask / todos.py

diff --git a/plomtask/todos.py b/plomtask/todos.py
index 9b9bc0b95527a901bd5a6008e1707f719df74b06..a874a6d7d6ba9a3596301ead4c4a024c3594748b 100644 (file)
--- a/plomtask/todos.py
+++ b/plomtask/todos.py
@@ -222,6 +222,8 @@ class Todo(BaseModel[int], ConditionsRelations):
             raise NotFoundException('Process of Todo without ID (not saved?)')
         self.save_core(db_conn)
         assert isinstance(self.id_, int)
+        db_conn.rewrite_relations('todo_children', 'child', self.id_,
+                                  [[p.id_] for p in self.parents])
         db_conn.rewrite_relations('todo_children', 'parent', self.id_,
                                   [[c.id_] for c in self.children])
         db_conn.rewrite_relations('todo_conditions', 'todo', self.id_,
@@ -230,3 +232,19 @@ class Todo(BaseModel[int], ConditionsRelations):
                                   [[c.id_] for c in self.enables])
         db_conn.rewrite_relations('todo_disables', 'todo', self.id_,
                                   [[c.id_] for c in self.disables])
+
+    def remove(self, db_conn: DatabaseConnection) -> None:
+        """Remove from DB, including relations."""
+        assert isinstance(self.id_, int)
+        children_to_remove = self.children[:]
+        parents_to_remove = self.parents[:]
+        for child in children_to_remove:
+            self.remove_child(child)
+        for parent in parents_to_remove:
+            parent.remove_child(self)
+        db_conn.delete_where('todo_children', 'parent', self.id_)
+        db_conn.delete_where('todo_children', 'child', self.id_)
+        db_conn.delete_where('todo_conditions', 'todo', self.id_)
+        db_conn.delete_where('todo_enables', 'todo', self.id_)
+        db_conn.delete_where('todo_disables', 'todo', self.id_)
+        super().remove(db_conn)