Extend POST tests, and handling of missing form data.

[plomtask] / tests / processes.py

diff --git a/tests/processes.py b/tests/processes.py
index 399eb9dfc354e73db88858a16dc10178f2825297..88a7a6c006912dddc3fcc86af4a1691a5982db6c 100644 (file)
--- a/tests/processes.py
+++ b/tests/processes.py
@@ -1,9 +1,8 @@
 """Test Processes module."""
 from unittest import TestCase
-from urllib.parse import urlencode
 from tests.utils import TestCaseWithDB, TestCaseWithServer
 from plomtask.processes import Process
-from plomtask.exceptions import NotFoundException
+from plomtask.exceptions import NotFoundException, BadFormatException
 
 
 class TestsSansDB(TestCase):
@@ -25,10 +24,8 @@ class TestsWithDB(TestCaseWithDB):
         p_saved.save(self.db_conn)
         self.assertEqual(p_saved.id_,
                          Process.by_id(self.db_conn, 1, create=False).id_)
-        p_saved = Process(0)
-        p_saved.save(self.db_conn)
-        self.assertEqual(p_saved.id_,
-                         Process.by_id(self.db_conn, 2, create=False).id_)
+        with self.assertRaises(BadFormatException):
+            p_saved = Process(0)
         p_saved = Process(5)
         p_saved.save(self.db_conn)
         self.assertEqual(p_saved.id_,
@@ -50,8 +47,6 @@ class TestsWithDB(TestCaseWithDB):
             Process.by_id(self.db_conn, 1, create=False)
         self.assertNotEqual(Process(1).id_,
                             Process.by_id(self.db_conn, None, create=True).id_)
-        self.assertNotEqual(Process(1).id_,
-                            Process.by_id(self.db_conn, 0, create=True).id_)
         self.assertEqual(Process(1).id_,
                          Process.by_id(self.db_conn, 1, create=True).id_)
         self.assertEqual(Process(2).id_,
@@ -72,26 +67,38 @@ class TestsWithServer(TestCaseWithServer):
 
     def test_do_POST_process(self) -> None:
         """Test POST /process and its effect on the database."""
-        def post_data_to_expect(form_data: dict[str, object],
-                                to_: str, expect: int) -> None:
-            encoded_form_data = urlencode(form_data).encode('utf-8')
-            headers = {'Content-Type': 'application/x-www-form-urlencoded',
-                       'Content-Length': str(len(encoded_form_data))}
-            self.conn.request('POST', to_,
-                              body=encoded_form_data, headers=headers)
-            self.assertEqual(self.conn.getresponse().status, expect)
         form_data = {'title': 'foo', 'description': 'foo', 'effort': 1.0}
-        post_data_to_expect(form_data, '/process?id=FOO', 401)
+        self.post_to(form_data, '/process?id=FOO')
+        self.assertEqual(self.conn.getresponse().status, 400)
         form_data['effort'] = 'foo'
-        post_data_to_expect(form_data, '/process?id=', 401)
+        self.post_to(form_data, '/process?id=')
+        self.assertEqual(self.conn.getresponse().status, 400)
         form_data['effort'] = None
-        post_data_to_expect(form_data, '/process?id=', 401)
+        self.post_to(form_data, '/process?id=')
+        self.assertEqual(self.conn.getresponse().status, 400)
+        form_data = {}
+        self.post_to(form_data, '/process?id=')
+        self.assertEqual(self.conn.getresponse().status, 400)
+        form_data = {'title': '', 'description': ''}
+        self.post_to(form_data, '/process?id=')
+        self.assertEqual(self.conn.getresponse().status, 400)
+        form_data = {'title': '', 'effort': 1}
+        self.post_to(form_data, '/process?id=')
+        self.assertEqual(self.conn.getresponse().status, 400)
+        form_data = {'description': '', 'effort': 1}
+        self.post_to(form_data, '/process?id=')
+        self.assertEqual(self.conn.getresponse().status, 400)
         form_data = {'title': None, 'description': 1, 'effort': 1.0}
-        post_data_to_expect(form_data, '/process?id=', 302)
+        self.post_to(form_data, '/process?id=')
+        self.check_redirect('/')
         retrieved = Process.by_id(self.db_conn, 1)
         self.assertEqual(retrieved.title.newest, 'None')
         self.assertEqual([p.id_ for p in Process.all(self.db_conn)],
                          [retrieved.id_])
+        self.post_to(form_data, '/process?id=1')
+        self.check_redirect('/')
+        self.post_to(form_data, '/process')
+        self.check_redirect('/')
 
     def test_do_GET(self) -> None:
         """Test /process and /processes response codes."""
@@ -100,8 +107,8 @@ class TestsWithServer(TestCaseWithServer):
         self.conn.request('GET', '/process?id=')
         self.assertEqual(self.conn.getresponse().status, 200)
         self.conn.request('GET', '/process?id=0')
-        self.assertEqual(self.conn.getresponse().status, 200)
+        self.assertEqual(self.conn.getresponse().status, 400)
         self.conn.request('GET', '/process?id=FOO')
-        self.assertEqual(self.conn.getresponse().status, 401)
+        self.assertEqual(self.conn.getresponse().status, 400)
         self.conn.request('GET', '/processes')
         self.assertEqual(self.conn.getresponse().status, 200)