X-Git-Url: https://plomlompom.com/repos/?a=blobdiff_plain;f=src%2Fserver%2Ffield_of_view.c;h=e279babae9d1dce791d107054cd8792717b7dec2;hb=cf0d81ea863df7adb1bdd862708571b0e40a73cb;hp=4b1ac00194d6a9498b2e3a5a3a8bba818bb147cd;hpb=3dedf6344c941891491773d1cc5d647aa664b218;p=plomrogue

diff --git a/src/server/field_of_view.c b/src/server/field_of_view.c
index 4b1ac00..e279bab 100644
--- a/src/server/field_of_view.c
+++ b/src/server/field_of_view.c
@@ -6,8 +6,9 @@
 #include <string.h> /* memset() */
 #include "../common/rexit.h" /* exit_trouble() */
 #include "../common/try_malloc.h" /* try_malloc() */
+#include "../common/yx_uint8.h" /* yx_uint8 */
+#include "map.h" /* mv_yx_in_dir_legal() */
 #include "things.h" /* Thing, ThingInMemory, add_thing_to_memory_map() */
-#include "yx_uint8.h" /* yx_uint8 */
 #include "world.h" /* world  */
 
 
@@ -30,22 +31,6 @@ struct shadow_angle
 
 
 
-/* Move "yx" into hex direction "d". */
-static void mv_yx_in_hex_dir(char d, struct yx_uint8 * yx);
-
-/* Move "yx" into hex direction "d". If this moves "yx" beyond the minimal (0)
- * or maximal (UINT8_MAX) column or row, it wraps to the opposite side. Such
- * wrapping is returned as a wraps enum value and stored, so that further calls
- * to move "yx" back into the opposite direction may unwrap it again. Pass an
- * "unwrap" of !0 to re-set the internal wrap memory to 0.
- */
-static uint8_t mv_yx_in_dir_wrap(char d, struct yx_uint8 * yx, uint8_t unwrap);
-
-/* Wrapper to mv_yx_in_dir_wrap(), returns 1 if the wrapped function moved "yx"
- * within the wrap borders and the map size, else 0.
- */
-static uint8_t mv_yx_in_dir_legal(char dir, struct yx_uint8 * yx);
-
 /* Recalculate angle < 0 or > CIRCLE to a value between these two limits. */
 static uint32_t correct_angle(int32_t angle);
 
@@ -91,86 +76,6 @@ static void update_map_memory(struct Thing * t, uint32_t map_size);
 
 
 
-static void mv_yx_in_hex_dir(char d, struct yx_uint8 * yx)
-{
-    if     (d == 'e')
-    {
-        yx->x = yx->x + (yx->y % 2);
-        yx->y--;
-    }
-    else if (d == 'd')
-    {
-        yx->x++;
-    }
-    else if (d == 'c')
-    {
-        yx->x = yx->x + (yx->y % 2);
-        yx->y++;
-    }
-    else if (d == 'x')
-    {
-        yx->x = yx->x - !(yx->y % 2);
-        yx->y++;
-    }
-    else if (d == 's')
-    {
-        yx->x--;
-    }
-    else if (d == 'w')
-    {
-        yx->x = yx->x - !(yx->y % 2);
-        yx->y--;
-    }
-}
-
-
-
-static uint8_t mv_yx_in_dir_wrap(char d, struct yx_uint8 * yx, uint8_t unwrap)
-{
-    static int8_t wrap_west_east   = 0;
-    static int8_t wrap_north_south = 0;
-    if (unwrap)
-    {
-        wrap_west_east = wrap_north_south = 0;
-        return 0;
-    }
-    struct yx_uint8 original;
-    original.y = yx->y;
-    original.x = yx->x;
-    mv_yx_in_hex_dir(d, yx);
-    if      (strchr("edc", d) && yx->x < original.x)
-    {
-        wrap_west_east++;
-    }
-    else if (strchr("xsw", d) && yx->x > original.x)
-    {
-        wrap_west_east--;
-    }
-    if      (strchr("we", d) && yx->y > original.y)
-    {
-        wrap_north_south--;
-    }
-    else if (strchr("xc", d) && yx->y < original.y)
-    {
-        wrap_north_south++;
-    }
-    return (wrap_west_east != 0) + (wrap_north_south != 0);
-}
-
-
-
-static uint8_t mv_yx_in_dir_legal(char dir, struct yx_uint8 * yx)
-{
-    uint8_t wraptest = mv_yx_in_dir_wrap(dir, yx, 0);
-    if (!wraptest && yx->x < world.map.length && yx->y < world.map.length)
-    {
-        return 1;
-    }
-    return 0;
-}
-
-
-
 static uint32_t correct_angle(int32_t angle)
 {
     while (angle < 0)
@@ -374,7 +279,7 @@ static void update_map_memory(struct Thing * t_eye, uint32_t map_size)
     struct ThingInMemory * tm = t_eye->t_mem;
     struct ThingInMemory * tm_prev = NULL;
     struct ThingInMemory * tm_next = NULL;
-    for (; tm != NULL; tm = tm_next)
+    for (; tm; tm = tm_next)
     {
         tm_next = tm->next;
         if ('v' == t_eye->fov_map[tm->pos.y * world.map.length + tm->pos.x])
@@ -393,7 +298,7 @@ static void update_map_memory(struct Thing * t_eye, uint32_t map_size)
         tm_prev = tm;
     }
     struct Thing * t = world.things;
-    for (; t != NULL; t = t->next)
+    for (; t; t = t->next)
     {
         if (   !t->lifepoints
             && 'v' == t_eye->fov_map[t->pos.y * world.map.length + t->pos.x])
@@ -410,19 +315,19 @@ extern void build_fov_map(struct Thing * t)
     uint32_t map_size = world.map.length * world.map.length;
     t->fov_map = t->fov_map ? t->fov_map : try_malloc(map_size, __func__);
     memset(t->fov_map, 'v', map_size);
-    struct yx_uint8 test_pos = t->pos;
     struct shadow_angle * shadows = NULL;
+    struct yx_uint8 test_pos = t->pos;
     char * circle_dirs = "xswedc";
     uint16_t dist;
-    uint8_t first_round, circle_on_map;
-    for (first_round = 1, dist = 1, circle_on_map = 1; circle_on_map; dist++)
+    uint8_t circle_on_map;
+    for (dist = 1, circle_on_map = 1; circle_on_map; dist++)
     {
-        if (!first_round)
+        if (1 != dist)
         {
             mv_yx_in_dir_legal('c', &test_pos);
         }
         char dir = 'd';
-        uint8_t i_dir = first_round = circle_on_map = 0;
+        uint8_t i_dir = circle_on_map = 0;
         uint16_t i_dist, hex_i;
         for (hex_i = 0, i_dist = 1; hex_i < 6 * dist; i_dist++, hex_i++)
         {
@@ -439,7 +344,7 @@ extern void build_fov_map(struct Thing * t)
             }
         }
     }
-    mv_yx_in_dir_wrap(0, NULL, 1);
+    mv_yx_in_dir_legal(0, NULL);
     free_angles(shadows);
     update_map_memory(t, map_size);
 }