X-Git-Url: https://plomlompom.com/repos/?a=blobdiff_plain;f=src%2Fwindows.c;h=f75544bd4753fa06d64f46382499a8b92f7fbfec;hb=c1a7e6cdb13cd7d883424afdf0fe08e9a10fbc28;hp=8af2ba259411500fa73d3c22ce4483d458bb4051;hpb=bed76e36029b889501cf45e6852830fbfa35ea11;p=plomrogue

diff --git a/src/windows.c b/src/windows.c
index 8af2ba2..f75544b 100644
--- a/src/windows.c
+++ b/src/windows.c
@@ -1,7 +1,7 @@
 /* windows.c */
 
 #include "windows.h"
-#include <stdint.h>    /* for uint8_t, uint16_t, uint32_t */
+#include <stdint.h>    /* for uint8_t, uint16_t, uint32_t, UINT16_MAX */
 #include <ncurses.h>   /* for typedefs WINDOW, chtype, wresize(), getmaxx(), */
                        /* getmaxy(), supbad(), delwin(), mvwaddch(),         */
                        /* mvwaddstr(), newpad(), wnoutrefres(), erase(),     */
@@ -13,7 +13,7 @@
 
 
 /* Fit virtual screen's width to minimum width demanded by current windows'
- * geometries. Returns 0 on success, 1 on (pad memory allocation) error.
+ * geometries.
  */
 static uint8_t refit_pad(struct WinMeta * wmeta);
 
@@ -21,15 +21,13 @@ static uint8_t refit_pad(struct WinMeta * wmeta);
 
 /* Update geometry (sizes, positions) of window "w" and its successors in the
  * window chain. For the positioning algorithm place_win() is used.
- *
- * update_wins() returns 0 on success, 1 on (pad/window memory alloc.) error.
  */
 static uint8_t update_wins(struct WinMeta * wmeta, struct Win * w);
 static void place_win(struct WinMeta * wmeta, struct Win * w);
 
 
 
-/* Destroy window "w"'s ncurses window (and set w.Frame.curses_win to 0). */
+/* Destroy window "w"'s ncurses WINDOW (and set w.Frame.curses_win to 0). */
 static void destroy_win(struct Win * w);
 
 
@@ -42,13 +40,13 @@ static void draw_wins(struct Win * w);
 /* draw_win_borderlines() draws the vertical and horizontal borders of window
  * "w" sans corners into the virtual screen "pad", and draws the top border
  * line as the windows' title bar (highlighted if the window is described
- * active by "active" being set). draw_wins_borderlines().
+ * active by "active" being == 1).
  *
  * draw_wins_borderlines() calls draw_win_borderlines() recursively on all
  * windows from "w" on. "w_active" is a pointer to the one window that
  * draw_win_borderlines() is supposed to handle as the active window.
  *
- * Finally, draw_wins_bordercorners draws into "pad" the borders of window "w"
+ * Finally, draw_wins_bordercorners() draws into "pad" the borders of window "w"
  * and all its successors.
  */
 static void draw_win_borderlines(struct Win * w, char active, WINDOW * pad);
@@ -58,23 +56,35 @@ static void draw_wins_bordercorners(struct Win * w, WINDOW * pad);
 
 
 
+/* Shift active window forwards / backwards in window chain. */
+static void shift_win_forward(struct WinMeta * wmeta);
+static void shift_win_backward(struct WinMeta * wmeta);
+
+
+
 static uint8_t refit_pad(struct WinMeta * wmeta)
 {
     /* Determine rightmost window column. */
-    uint16_t lastwincol = 0;
-    struct Win * w_p = wmeta->chain_start;
+    uint32_t lastwincol = 0;
+    struct Win * w_p = wmeta->_chain_start;
     while (w_p != 0)
     {
-        if (w_p->start.x + w_p->frame.size.x > lastwincol + 1)
+        if ((uint32_t) w_p->_start.x + (uint32_t) w_p->frame.size.x
+            > lastwincol + 1)
         {
-            lastwincol = w_p->start.x + w_p->frame.size.x - 1;
+            lastwincol = (uint32_t) w_p->_start.x
+                         + (uint32_t) w_p->frame.size.x - 1;
         }
-        w_p = w_p->next;
+        w_p = w_p->_next;
     }
 
     /* Only resize the pad if the rightmost window column has changed. */
     if (getmaxx(wmeta->padframe.curses_win) != lastwincol)
     {
+        if (lastwincol + 2 > UINT16_MAX)
+        {
+            return 2;
+        }
         return (ERR == wresize(wmeta->padframe.curses_win,
                                getmaxy(wmeta->padframe.curses_win),
                                lastwincol + 2));
@@ -91,21 +101,22 @@ static uint8_t update_wins(struct WinMeta * wmeta, struct Win * w)
         destroy_win(w);
     }
     place_win(wmeta, w);
-    if (0 != refit_pad(wmeta))
+    uint8_t test_refit = refit_pad(wmeta);
+    if (0 != test_refit)
     {
-        return 1;
+        return test_refit;
     }
-    WINDOW * test = subpad(wmeta->padframe.curses_win,
-                           w->frame.size.y, w->frame.size.x,
-                           w->start.y, w->start.x);
-    if (NULL == test)
+    WINDOW * subpad_test = subpad(wmeta->padframe.curses_win,
+                                  w->frame.size.y, w->frame.size.x,
+                                  w->_start.y, w->_start.x);
+    if (NULL == subpad_test)
     {
         return 1;
     }
-    w->frame.curses_win = test;
-    if (0 != w->next)
+    w->frame.curses_win = subpad_test;
+    if (0 != w->_next)
     {
-        return update_wins(wmeta, w->next);
+        return update_wins(wmeta, w->_next);
     }
     return 0;
 }
@@ -115,29 +126,29 @@ static uint8_t update_wins(struct WinMeta * wmeta, struct Win * w)
 static void place_win(struct WinMeta * wmeta, struct Win * w)
 {
     /* First window goes into the upper-left corner. */
-    w->start.x = 0;
-    w->start.y = 1;                             /* Leave space for title bar. */
-    if (0 != w->prev)
+    w->_start.x = 0;
+    w->_start.y = 1;                            /* Leave space for title bar. */
+    if (0 != w->_prev)
     {
 
         /* Non-first window fallbacks to: fit rightwards of rightmost border. */
-        struct Win * w_top = w->prev;
-        while (w_top->start.y != 1)
+        struct Win * w_top = w->_prev;
+        while (w_top->_start.y != 1)
         {
-            w_top = w_top->prev;
+            w_top = w_top->_prev;
         }
-        w->start.x = w_top->start.x + w_top->frame.size.x + 1;
+        w->_start.x = w_top->_start.x + w_top->frame.size.x + 1;
 
         /* Fit window below its predecessor if that one directly thrones over
          * empty space wide and high enough.
          */
-        uint16_t w_prev_maxy = w->prev->start.y
-                               + getmaxy(w->prev->frame.curses_win);
-        if (   w->frame.size.x <= w->prev->frame.size.x
+        uint16_t w_prev_maxy = w->_prev->_start.y
+                               + getmaxy(w->_prev->frame.curses_win);
+        if (   w->frame.size.x <= w->_prev->frame.size.x
             && w->frame.size.y <  wmeta->padframe.size.y - w_prev_maxy)
         {
-            w->start.x = w->prev->start.x;
-            w->start.y = w_prev_maxy + 1;
+            w->_start.x = w->_prev->_start.x;
+            w->_start.y = w_prev_maxy + 1;
         }
 
         /* Failing that, try to open a new sub column below the nearest
@@ -145,29 +156,29 @@ static void place_win(struct WinMeta * wmeta, struct Win * w)
          */
         else
         {
-            struct Win * w_up = w->prev;
+            struct Win * w_up = w->_prev;
             struct Win * w_upup = w_up;
             uint16_t widthdiff;
             while (w_up != w_top)
             {
-                w_upup = w_up->prev;
+                w_upup = w_up->_prev;
                 while (1)
                 {
-                    if (w_up->start.y != w_upup->start.y)
+                    if (w_up->_start.y != w_upup->_start.y)
                     {
                         break;
                     }
-                    w_upup = w_upup->prev;
+                    w_upup = w_upup->_prev;
                 }
-                w_prev_maxy = w_upup->start.y
+                w_prev_maxy = w_upup->_start.y
                               + getmaxy(w_upup->frame.curses_win);
-                widthdiff = (w_upup->start.x + w_upup->frame.size.x)
-                            - (w_up->start.x + w_up->frame.size.x);
+                widthdiff = (w_upup->_start.x + w_upup->frame.size.x)
+                            - (w_up->_start.x + w_up->frame.size.x);
                 if (   w->frame.size.y < wmeta->padframe.size.y - w_prev_maxy
                     && w->frame.size.x < widthdiff)
                 {
-                    w->start.x = w_up->start.x + w_up->frame.size.x + 1 ;
-                    w->start.y = w_prev_maxy + 1;
+                    w->_start.x = w_up->_start.x + w_up->frame.size.x + 1 ;
+                    w->_start.y = w_prev_maxy + 1;
                     break;
                 }
                 w_up = w_upup;
@@ -188,10 +199,10 @@ static void destroy_win(struct Win * w)
 
 static void draw_wins(struct Win * w)
 {
-    w->draw(w);
-    if (0 != w->next)
+    w->_draw(w);
+    if (0 != w->_next)
     {
-        draw_wins(w->next);
+        draw_wins(w->_next);
     }
 }
 
@@ -201,15 +212,15 @@ static void draw_win_borderlines(struct Win * w, char active, WINDOW * pad)
 {
     /* Draw vertical and horizontal border lines. */
     uint16_t y, x;
-    for (y = w->start.y; y <= w->start.y + w->frame.size.y; y++)
+    for (y = w->_start.y; y <= w->_start.y + w->frame.size.y; y++)
     {
-        mvwaddch(pad, y, w->start.x - 1,               '|');
-        mvwaddch(pad, y, w->start.x + w->frame.size.x, '|');
+        mvwaddch(pad, y, w->_start.x - 1,               '|');
+        mvwaddch(pad, y, w->_start.x + w->frame.size.x, '|');
     }
-    for (x = w->start.x; x <= w->start.x + w->frame.size.x; x++)
+    for (x = w->_start.x; x <= w->_start.x + w->frame.size.x; x++)
     {
-        mvwaddch(pad, w->start.y - 1,               x, '-');
-        mvwaddch(pad, w->start.y + w->frame.size.y, x, '-');
+        mvwaddch(pad, w->_start.y - 1,               x, '-');
+        mvwaddch(pad, w->_start.y + w->frame.size.y, x, '-');
     }
 
     /* Draw as much as possible of the title into center of top border line. */
@@ -217,21 +228,21 @@ static void draw_win_borderlines(struct Win * w, char active, WINDOW * pad)
     if (w->frame.size.x >= min_title_length_visible)
     {
         uint16_t title_offset = 0;
-        if (w->frame.size.x > strlen(w->title) + 2)
+        if (w->frame.size.x > strlen(w->_title) + 2)
         {
-            title_offset = (w->frame.size.x - (strlen(w->title) + 2)) / 2;
-        }                                     /* +2 is for padding/decoration */
-        uint16_t length_visible = strnlen(w->title, w->frame.size.x - 2);
+            title_offset = (w->frame.size.x - (strlen(w->_title) + 2)) / 2;
+        }                                    /* +2 is for padding/decoration */
+        uint16_t length_visible = strnlen(w->_title, w->frame.size.x - 2);
         char title[length_visible + 3];
         char decoration = ' ';
         if (1 == active)
         {
             decoration = '$';
         }
-        memcpy(title + 1, w->title, length_visible);
+        memcpy(title + 1, w->_title, length_visible);
         title[0] = title[length_visible + 1] = decoration;
         title[length_visible + 2] = '\0';
-        mvwaddstr(pad, w->start.y - 1, w->start.x + title_offset, title);
+        mvwaddstr(pad, w->_start.y - 1, w->_start.x + title_offset, title);
     }
 }
 
@@ -246,9 +257,9 @@ static void draw_wins_borderlines(struct Win * w, struct Win * w_active,
         active = 1;
     }
     draw_win_borderlines(w, active, pad);
-    if (0 != w->next)
+    if (0 != w->_next)
     {
-        draw_wins_borderlines(w->next, w_active, pad);
+        draw_wins_borderlines(w->_next, w_active, pad);
     }
 }
 
@@ -256,14 +267,96 @@ static void draw_wins_borderlines(struct Win * w, struct Win * w_active,
 
 static void draw_wins_bordercorners(struct Win * w, WINDOW * pad)
 {
-    mvwaddch(pad, w->start.y - 1, w->start.x - 1, '+');
-    mvwaddch(pad, w->start.y - 1, w->start.x + w->frame.size.x, '+');
-    mvwaddch(pad, w->start.y + w->frame.size.y, w->start.x - 1, '+');
+    mvwaddch(pad, w->_start.y - 1, w->_start.x - 1, '+');
+    mvwaddch(pad, w->_start.y - 1, w->_start.x + w->frame.size.x, '+');
+    mvwaddch(pad, w->_start.y + w->frame.size.y, w->_start.x - 1, '+');
     mvwaddch(pad,
-             w->start.y + w->frame.size.y, w->start.x + w->frame.size.x, '+');
-    if (0 != w->next)
+             w->_start.y + w->frame.size.y, w->_start.x + w->frame.size.x, '+');
+    if (0 != w->_next)
+    {
+        draw_wins_bordercorners(w->_next, pad);
+    }
+}
+
+
+
+static void shift_win_forward(struct WinMeta * wmeta)
+{
+    if (wmeta->active == wmeta->_chain_end)
+    {
+        wmeta->_chain_end = wmeta->active->_prev;
+        wmeta->_chain_end->_next = 0;
+        wmeta->active->_next = wmeta->_chain_start;
+        wmeta->active->_next->_prev = wmeta->active;
+        wmeta->_chain_start = wmeta->active;
+        wmeta->_chain_start->_prev = 0;
+    }
+    else
+    {
+        struct Win * old_prev = wmeta->active->_prev;
+        struct Win * old_next = wmeta->active->_next;
+        if (wmeta->_chain_end == wmeta->active->_next)
+        {
+            wmeta->_chain_end = wmeta->active;
+            wmeta->active->_next = 0;
+        }
+        else
+        {
+            wmeta->active->_next = old_next->_next;
+            wmeta->active->_next->_prev = wmeta->active;
+        }
+        if (wmeta->_chain_start == wmeta->active)
+        {
+            wmeta->_chain_start = old_next;
+        }
+        else
+        {
+            old_prev->_next = old_next;
+        }
+        old_next->_prev = old_prev;
+        old_next->_next = wmeta->active;
+        wmeta->active->_prev = old_next;
+    }
+}
+
+
+
+static void shift_win_backward(struct WinMeta * wmeta)
+{
+    if (wmeta->active == wmeta->_chain_start)
+    {
+        wmeta->_chain_start = wmeta->active->_next;
+        wmeta->_chain_start->_prev = 0;
+        wmeta->active->_prev = wmeta->_chain_end;
+        wmeta->active->_prev->_next = wmeta->active;
+        wmeta->_chain_end = wmeta->active;
+        wmeta->_chain_end->_next = 0;
+    }
+    else
     {
-        draw_wins_bordercorners(w->next, pad);
+        struct Win * old_prev = wmeta->active->_prev;
+        struct Win * old_next = wmeta->active->_next;
+        if (wmeta->_chain_start == wmeta->active->_prev)
+        {
+            wmeta->_chain_start = wmeta->active;
+            wmeta->active->_prev = 0;
+        }
+        else
+        {
+            wmeta->active->_prev = old_prev->_prev;
+            wmeta->active->_prev->_next = wmeta->active;
+        }
+        if (wmeta->_chain_end == wmeta->active)
+        {
+            wmeta->_chain_end = old_prev;
+        }
+        else
+        {
+            old_next->_prev = old_prev;
+        }
+        old_prev->_next = old_next;
+        old_prev->_prev = wmeta->active;
+        wmeta->active->_next = old_prev;
     }
 }
 
@@ -271,70 +364,101 @@ static void draw_wins_bordercorners(struct Win * w, WINDOW * pad)
 
 extern uint8_t init_win_meta(WINDOW * screen, struct WinMeta * wmeta)
 {
-    wmeta->screen              = screen;
-    wmeta->padframe.size.y     = getmaxy(screen);
-    wmeta->padframe.size.x     = getmaxx(screen);
-    wmeta->chain_start         = 0;
-    wmeta->chain_end           = 0;
+    wmeta->_screen             = screen;
+    uint32_t maxy_test         = getmaxy(screen);
+    uint32_t maxx_test         = getmaxx(screen);
+    if (maxy_test > UINT16_MAX || maxx_test > UINT16_MAX)
+    {
+        return 2;
+    }
+    wmeta->padframe.size.y     = maxy_test;
+    wmeta->padframe.size.x     = maxx_test;
+    wmeta->_chain_start        = 0;
+    wmeta->_chain_end          = 0;
     wmeta->pad_offset          = 0;
-    WINDOW * test;
-    test = newpad(wmeta->padframe.size.y, 1);
-    if (NULL == test)
+    WINDOW * pad_test          = newpad(wmeta->padframe.size.y, 1);
+    if (NULL == pad_test)
     {
         return 1;
     }
-    wmeta->padframe.curses_win = test;
+    wmeta->padframe.curses_win = pad_test;
     wmeta->active              = 0;
     return 0;
 }
 
 
 
-extern struct Win init_win(struct WinMeta * wmeta, char * title,
-                           uint16_t height, uint16_t width,
-                           void * data, void * func)
+extern uint8_t init_win(struct WinMeta * wmeta, struct Win ** wp, char * title,
+                        int16_t height, int16_t width,
+                        void * data, void * func)
 {
-    struct Win w;
-    w.prev             = 0;
-    w.next             = 0;
-    w.frame.curses_win = 0;
-    w.title            = title;
-    w.data             = data;
-    w.draw             = func;
-    if (width > 0)
+    struct Win * w = malloc(sizeof(struct Win));
+    if (NULL == w)
+    {
+        return 1;
+    }
+    w->_prev             = 0;
+    w->_next             = 0;
+    w->frame.curses_win  = 0;
+    w->_title             = malloc(strlen(title) + 1);
+    if (NULL == w->_title)
+    {
+        return 1;
+    }
+    sprintf(w->_title, "%s", title);
+    w->data              = data;
+    w->_draw             = func;
+    if      (0 < width)
     {
-        w.frame.size.x = width;
+        w->frame.size.x = width;
+    }
+    else if (0 > width)
+    {
+        w->frame.size.x = wmeta->padframe.size.x + width;
     }
     else
     {
-        w.frame.size.x = 1;
+        w->frame.size.x = wmeta->padframe.size.x;
+    }
+    if      (0 < height && height <= wmeta->padframe.size.y - 1)
+    {
+        w->frame.size.y = height;
     }
-    if (height > 0 && height <= wmeta->padframe.size.y - 1)
+    else if (0 > height && wmeta->padframe.size.y + (height - 1) > 0)
     {
-        w.frame.size.y = height;
+        w->frame.size.y = wmeta->padframe.size.y + (height - 1);
     }
     else
     {
-        w.frame.size.y = wmeta->padframe.size.y - 1;
+        w->frame.size.y = wmeta->padframe.size.y - 1;
     }
-    return w;
+    *wp = w;
+    return 0;
+}
+
+
+
+extern void free_win(struct Win * win)
+{
+    free(win->_title);
+    free(win);
 }
 
 
 
 extern uint8_t append_win(struct WinMeta * wmeta, struct Win * w)
 {
-    if (0 != wmeta->chain_start)
+    if (0 != wmeta->_chain_start)
     {
-        w->prev = wmeta->chain_end;
-        wmeta->chain_end->next = w;
+        w->_prev = wmeta->_chain_end;
+        wmeta->_chain_end->_next = w;
     }
     else
     {
         wmeta->active = w;
-        wmeta->chain_start = w;
+        wmeta->_chain_start = w;
     }
-    wmeta->chain_end = w;
+    wmeta->_chain_end = w;
     return update_wins(wmeta, w);
 }
 
@@ -344,39 +468,40 @@ extern uint8_t suspend_win(struct WinMeta * wmeta, struct Win * w)
 {
     destroy_win(w);
 
-    if (wmeta->chain_start != w)
+    if (wmeta->_chain_start != w)
     {
-        w->prev->next = w->next;
+        w->_prev->_next = w->_next;
     }
     else
     {
-        wmeta->chain_start = w->next;
+        wmeta->_chain_start = w->_next;
     }
     char pad_refitted = 0;
-    if (wmeta->chain_end != w)
+    if (wmeta->_chain_end != w)
     {
-        w->next->prev = w->prev;
+        w->_next->_prev = w->_prev;
         if (wmeta->active == w)
         {
-            wmeta->active = w->next;
+            wmeta->active = w->_next;
         }
-        if (0 != update_wins(wmeta, w->next)) /* Positioning of successor    */
-        {                                     /* windows may be affected /    */
-            return 1;                         /* need correction.             */
-        }                                     /* Note that update_wins()      */
-        pad_refitted = 1;                     /* already refits the  pad,     */
-    }                                         /* voiding later need for that. */
+        uint8_t test = update_wins(wmeta, w->_next);/* Positioning of         */
+        if (0 != test)                              /* successor windows may  */
+        {                                           /* be affected / need     */
+            return test;                            /* correction. Note that  */
+        }                                           /* update_wins() already  */
+        pad_refitted = 1;                           /* refits the pad, voiding*/
+    }                                               /* later need for that.   */
     else
     {
-        wmeta->chain_end = w->prev;
+        wmeta->_chain_end = w->_prev;
         if (wmeta->active == w)
         {
-            wmeta->active = w->prev;
+            wmeta->active = w->_prev;
         }
     }
 
-    w->prev = 0;
-    w->next = 0;
+    w->_prev = 0;
+    w->_next = 0;
 
     if (0 == pad_refitted)
     {
@@ -407,37 +532,37 @@ extern uint8_t resize_active_win(struct WinMeta * wmeta, struct yx_uint16 size)
         && size.y < wmeta->padframe.size.y)
     {
         wmeta->active->frame.size = size;
-        return update_wins(wmeta, wmeta->chain_start); /* Succeeding windows' */
-    }                                                  /* positioning may be  */
-    return 0;                                          /* affected.           */
-}                                                      /* TODO: Why start at  */
-                                                       /* chain_start then?   */
+        return update_wins(wmeta, wmeta->active); /* Positioning of following */
+    }                                             /* windows may be affected. */
+    return 0;
+}
+
 
 
 extern void cycle_active_win(struct WinMeta * wmeta, char dir)
 {
     if (0 != wmeta->active)
     {
-        if ('n' == dir)
+        if ('f' == dir)
         {
-            if (wmeta->active->next != 0)
+            if (wmeta->active->_next != 0)
             {
-                wmeta->active = wmeta->active->next;
+                wmeta->active = wmeta->active->_next;
             }
             else
             {
-                wmeta->active = wmeta->chain_start;
+                wmeta->active = wmeta->_chain_start;
             }
         }
         else
         {
-            if (wmeta->active->prev != 0)
+            if (wmeta->active->_prev != 0)
             {
-                wmeta->active = wmeta->active->prev;
+                wmeta->active = wmeta->active->_prev;
             }
             else
             {
-                wmeta->active = wmeta->chain_end;
+                wmeta->active = wmeta->_chain_end;
             }
         }
     }
@@ -447,136 +572,59 @@ extern void cycle_active_win(struct WinMeta * wmeta, char dir)
 
 extern uint8_t shift_active_win(struct WinMeta * wmeta, char dir)
 {
-    if (0 != wmeta->active                        /* No shifting with less    */
-        && wmeta->chain_start != wmeta->chain_end /* than one window visible. */
-        && (dir == 'f' || dir == 'b'))
+    if (   0 == wmeta->active                        /* No shifting with < 2  */
+        || wmeta->_chain_start == wmeta->_chain_end) /* windows visible.      */
     {
-        struct Win * w_shift = wmeta->active, * w_p, * w_p_next;
-
-        /* Check if shifting will lead to wrapping. */
-        char wrap = 0;
-        if (   (dir == 'f' && w_shift == wmeta->chain_end)
-            || (dir == 'b' && w_shift == wmeta->chain_start))
-        {
-            wrap = 1;
-        }
-
-        /* Suspend all visible windows, remember their order in wins[]. */
-        uint16_t i, i_max;
-        for (w_p  = wmeta->chain_start, i_max = 1;
-             w_p != wmeta->chain_end;
-             w_p  = w_p->next)
-        {
-            i_max++;
-        }
-        struct Win ** wins = malloc(i_max * sizeof(struct Win *));
-        if (NULL == wins)
-        {
-            return 1;
-        }
-        for (i = 0, w_p = wmeta->chain_start;
-             i < i_max;
-             i++)
-        {
-            w_p_next = w_p->next;
-            suspend_win(wmeta, w_p);
-            wins[i] = w_p;
-            w_p = w_p_next;
-        }
-
-        /* Re-append all previously visible windows in the new order. */
-        if (wrap)
-        {
-            if (dir == 'f')
-            {
-                if (0 != append_win(wmeta, w_shift))
-                {
-                    return 1;
-                }
-                for (i = 0; i < i_max - 1; i++)
-                {
-                    if (0 != append_win(wmeta, wins[i]))
-                    {
-                        return 1;
-                    }
-                }
-            }
-            else
-            {
-                for (i = 1; i < i_max; i++)
-                {
-                    if (0 != append_win(wmeta, wins[i]))
-                    {
-                        return 1;
-                    }
-                }
-                if (0 != append_win(wmeta, w_shift))
-                {
-                    return 1;
-                }
-            }
-        }
-        else
-        {
-            for (i = 0; i < i_max; i++)
-            {
-                if (   (dir == 'f' && w_shift == wins[i])
-                    || (dir == 'b' && w_shift == wins[i+1]))
-                {
-                    if (   0 != append_win(wmeta, wins[i+1])
-                        || 0 != append_win(wmeta, wins[i]))
-                    {
-                        return 1;
-                    }
-                    i++;
-                }
-                else
-                {
-                    if (0 != append_win(wmeta, wins[i]))
-                    {
-                        return 1;
-                    }
-                }
-            }
-        }
-        free(wins);
-
-        wmeta->active = w_shift;  /* Otherwise lastly appended win is active. */
+        return 0;
     }
-    return 0;
+    if ('f' == dir)
+    {
+        shift_win_forward(wmeta);
+    }
+    else
+    {
+        shift_win_backward(wmeta);
+    }
+    return update_wins(wmeta, wmeta->_chain_start);
 }
 
 
 
-extern void draw_all_wins(struct WinMeta * wmeta)
+extern uint8_t draw_all_wins(struct WinMeta * wmeta)
 {
     /* Empty everything before filling it a-new. */
     erase();
-    wnoutrefresh(wmeta->screen);
+    wnoutrefresh(wmeta->_screen);
     werase(wmeta->padframe.curses_win);
-    if (wmeta->chain_start)
+    if (wmeta->_chain_start)
     {
 
         /* Draw windows' contents first, then their borders. */
-        draw_wins(wmeta->chain_start);
-        draw_wins_borderlines(wmeta->chain_start, wmeta->active,
+        draw_wins(wmeta->_chain_start);
+        draw_wins_borderlines(wmeta->_chain_start, wmeta->active,
                               wmeta->padframe.curses_win);
-        draw_wins_bordercorners(wmeta->chain_start, wmeta->padframe.curses_win);
+        draw_wins_bordercorners(wmeta->_chain_start,wmeta->padframe.curses_win);
 
         /* Draw virtual screen scroll hints. */
         if (wmeta->pad_offset > 0)
         {
-            draw_scroll_hint(&wmeta->padframe,
-                             wmeta->pad_offset, wmeta->pad_offset + 1, '<');
+            if (draw_scroll_hint(&wmeta->padframe,
+                                 wmeta->pad_offset, wmeta->pad_offset + 1, '<'))
+            {
+                return 1;
+            }
         }
         if (wmeta->pad_offset + wmeta->padframe.size.x
             < getmaxx(wmeta->padframe.curses_win) - 1)
         {
-            draw_scroll_hint(&wmeta->padframe,
-                             wmeta->pad_offset + wmeta->padframe.size.x - 1,
-                             getmaxx(wmeta->padframe.curses_win)
-                             - (wmeta->pad_offset + wmeta->padframe.size.x),
-                             '>');
+            if (draw_scroll_hint(&wmeta->padframe,
+                                 wmeta->pad_offset + wmeta->padframe.size.x - 1,
+                                 getmaxx(wmeta->padframe.curses_win)
+                                 - (wmeta->pad_offset + wmeta->padframe.size.x),
+                                 '>'))
+            {
+                return 1;
+            }
         }
 
         /* Write virtual screen segment to be shown on physical screen into */
@@ -587,6 +635,7 @@ extern void draw_all_wins(struct WinMeta * wmeta)
 
     /* Only at the end write accumulated changes to the physical screen. */
     doupdate();
+    return 0;
 }