home · contact · privacy
Use request library to simplify page retrieval code.
[plomlombot-irc.git] / plomlombot.py
old mode 100644 (file)
new mode 100755 (executable)
index bea1422..f7c7e32
@@ -1,27 +1,50 @@
+#!/usr/bin/python3
+
+import argparse
 import socket
 import datetime
 import select
 import time
 import re
-import urllib.request
+import requests
 import html
+import html.parser
+
+# Defaults, may be overwritten by command line arguments.
+SERVER = "irc.freenode.net"
+PORT = 6667
+TIMEOUT = 240
+USERNAME = "plomlombot"
+NICKNAME = USERNAME
+
+
+class HTMLParser(html.parser.HTMLParser):
+    def __init__(self, html, tag):
+        super().__init__()
+        self._tag_to_check = tag
+        self._tag = ""
+        self.data = ""
+        self.feed(html)
+    def handle_starttag(self, tag, attrs):
+        if self.data == "" and tag == self._tag_to_check:
+            self._tag = tag
+    def handle_endtag(self, tag):
+        self._tag = ""
+    def handle_data(self, data):
+        if self._tag != "":
+            self.data = data
 
-servernet = "irc.freenode.net"
-port = 6667
-servername = ""
-timeout = 240
-username = "plomlombot"
-nickname = username
-channel = "#zrolaps"
 
 class ExceptionForRestart(Exception):
     pass
 
+
 class IO:
 
-    def __init__(self, servernet, port):
+    def __init__(self, server, port, timeout):
+        self.timeout = timeout
         self.socket = socket.socket()
-        self.socket.connect((servernet, port))
+        self.socket.connect((server, port))
         self.socket.setblocking(0)
         self.line_buffer = []
         self.rune_buffer = ""
@@ -29,11 +52,11 @@ class IO:
         self.servername = self.recv_line(send_ping=False).split(" ")[0][1:]
 
     def _pingtest(self, send_ping=True):
-        if self.last_pong + timeout < time.time():
+        if self.last_pong + self.timeout < time.time():
             print("SERVER NOT ANSWERING")
             raise ExceptionForRestart
         if send_ping:
-            self.send_line("PING " + nickname + " " + self.servername)
+            self.send_line("PING " + self.servername)
 
     def send_line(self, msg):
         msg = msg.replace("\r", " ")
@@ -41,7 +64,7 @@ class IO:
         if len(msg.encode("utf-8")) > 510:
             print("NOT SENT LINE TO SERVER (too long): " + msg)
         print("LINE TO SERVER: "
-            + str(datetime.datetime.now()) + ": " + msg)
+              + str(datetime.datetime.now()) + ": " + msg)
         msg = msg + "\r\n"
         msg_len = len(msg)
         total_sent_len = 0
@@ -56,16 +79,20 @@ class IO:
         if len(self.line_buffer) > 0:
             return self.line_buffer.pop(0)
         while True:
-            ready = select.select([self.socket], [], [], int(timeout / 2))
+            ready = select.select([self.socket], [], [], int(self.timeout / 2))
             if not ready[0]:
                 self._pingtest(send_ping)
                 return None
             self.last_pong = time.time()
-            received_runes = self.socket.recv(1024).decode("UTF-8")
+            received_bytes = self.socket.recv(1024)
+            try:
+                received_runes = received_bytes.decode("UTF-8")
+            except UnicodeDecodeError:
+                received_runes = received_bytes.decode("latin1")
             if len(received_runes) == 0:
                 print("SOCKET CONNECTION BROKEN")
                 raise ExceptionForRestart
-            self.rune_buffer += received_runes 
+            self.rune_buffer += received_runes
             lines_split = str.split(self.rune_buffer, "\r\n")
             self.line_buffer += lines_split[:-1]
             self.rune_buffer = lines_split[-1]
@@ -76,44 +103,42 @@ class IO:
         line = self._recv_line_wrapped(send_ping)
         if line:
             print("LINE FROM SERVER " + str(datetime.datetime.now()) + ": " +
-            line)
+                  line)
         return line
 
-def init_connection():
-    print("CONNECTING TO " + servernet)
-    io = IO(servernet, port)
+
+def init_session(server, port, timeout, nickname, username, channel):
+    print("CONNECTING TO " + server)
+    io = IO(server, port, timeout)
     io.send_line("NICK " + nickname)
     io.send_line("USER " + username + " 0 * : ")
     io.send_line("JOIN " + channel)
     return io
 
-def lineparser_loop():
+
+def lineparser_loop(io, nickname):
 
     def act_on_privmsg(tokens):
 
         def url_check(msg):
-            matches = re.findall("(https?://[^\s]+)", msg)
+
+            def notice(msg):
+                io.send_line("NOTICE " + target + " :" + msg)
+
+            matches = re.findall("(https?://[^\s>]+)", msg)
             for i in range(len(matches)):
                 url = matches[i]
                 try:
-                    webpage = urllib.request.urlopen(url, timeout=15)
-                except urllib.error.HTTPError as error:
-                    print("TROUBLE FOLLOWING URL: " + str(error))
+                    r = requests.get(url, timeout=15)
+                except (requests.exceptions.TooManyRedirects,
+                        requests.exceptions.ConnectionError,
+                        requests.exceptions.InvalidSchema) as error:
+                    notice("TROUBLE FOLLOWING URL: " + str(error))
                     continue
-                charset = webpage.info().get_content_charset()
-                if not charset:
-                    charset="utf-8"
-                content_type = webpage.info().get_content_type()
-                if not content_type in ('text/html', 'text/xml',
-                        'application/xhtml+xml'):
-                    print("TROUBLE INTERPRETING URL: bad content type "
-                            + content_type)
-                    continue
-                content = webpage.read().decode(charset)
-                title = str(content).split('<title>')[1].split('</title>')[0]
+                content = r.text
+                title = HTMLParser(content, "title").data
                 title = html.unescape(title)
-                io.send_line("PRIVMSG " + target + " :page title for url: "
-                    + title)
+                notice("PAGE TITLE FOR URL: " + title)
 
         sender = ""
         for rune in tokens[0]:
@@ -133,7 +158,7 @@ def lineparser_loop():
         msg = str.join(" ", tokens[3:])[1:]
         url_check(msg)
 
-    while 1:
+    while True:
         line = io.recv_line()
         if not line:
             continue
@@ -144,10 +169,36 @@ def lineparser_loop():
             if tokens[0] == "PING":
                 io.send_line("PONG " + tokens[1])
 
-while 1:
+
+def parse_command_line_arguments():
+    parser = argparse.ArgumentParser()
+    parser.add_argument("-s, --server", action="store", dest="server",
+                        default=SERVER,
+                        help="server or server net to connect to (default: "
+                        + SERVER + ")")
+    parser.add_argument("-p, --port", action="store", dest="port", type=int,
+                        default=PORT, help="port to connect to (default : "
+                        + str(PORT) + ")")
+    parser.add_argument("-t, --timeout", action="store", dest="timeout",
+                        type=int, default=TIMEOUT,
+                        help="timeout in seconds after which to attempt " +
+                        "reconnect (default: " + str(TIMEOUT) + ")")
+    parser.add_argument("-u, --username", action="store", dest="username",
+                        default=USERNAME, help="username to use (default: "
+                        + USERNAME + ")")
+    parser.add_argument("-n, --nickname", action="store", dest="nickname",
+                        default=NICKNAME, help="nickname to use (default: "
+                        + NICKNAME + ")")
+    parser.add_argument("CHANNEL", action="store", help="channel to join")
+    opts, unknown = parser.parse_known_args()
+    return opts
+
+opts = parse_command_line_arguments()
+while True:
     try:
-        io = init_connection()
-        lineparser_loop()
+        io = init_session(opts.server, opts.port, opts.timeout, opts.nickname,
+                          opts.username, opts.CHANNEL)
+        lineparser_loop(io, opts.nickname)
     except ExceptionForRestart:
         io.socket.close()
         continue