Base core models on BaseModel providing sensible defaults.

[plomtask] / plomtask / conditions.py

diff --git a/plomtask/conditions.py b/plomtask/conditions.py
index 5c57d85b9bfb7c402c538aba5716954e5a0a65d7..27ab62cf303084f4ae62add99ac4f6d39616d4f0 100644 (file)
--- a/plomtask/conditions.py
+++ b/plomtask/conditions.py
@@ -1,19 +1,18 @@
 """Non-doable elements of ProcessStep/Todo chains."""
 from __future__ import annotations
 from sqlite3 import Row
-from plomtask.db import DatabaseConnection
+from plomtask.db import DatabaseConnection, BaseModel
 from plomtask.misc import VersionedAttribute
-from plomtask.exceptions import BadFormatException, NotFoundException
+from plomtask.exceptions import NotFoundException
 
 
-class Condition:
+class Condition(BaseModel):
     """Non Process-dependency for ProcessSteps and Todos."""
+    table_name = 'conditions'
+    to_save = ['is_active']
 
     def __init__(self, id_: int | None, is_active: bool = False) -> None:
-        if (id_ is not None) and id_ < 1:
-            msg = f'illegal Condition ID, must be >=1: {id_}'
-            raise BadFormatException(msg)
-        self.id_ = id_
+        self.set_int_id(id_)
         self.is_active = is_active
         self.title = VersionedAttribute(self, 'condition_titles', 'UNNAMED')
         self.description = VersionedAttribute(self, 'condition_descriptions',
@@ -65,10 +64,8 @@ class Condition:
 
     def save(self, db_conn: DatabaseConnection) -> None:
         """Save self and its VersionedAttributes to DB and cache."""
-        cursor = db_conn.exec('REPLACE INTO conditions VALUES (?, ?)',
-                              (self.id_, self.is_active))
-        self.id_ = cursor.lastrowid
+        self.save_core(db_conn)
         self.title.save(db_conn)
         self.description.save(db_conn)
-        assert self.id_ is not None
+        assert isinstance(self.id_, int)
         db_conn.cached_conditions[self.id_] = self