home · contact · privacy
Some test refactoring.
[plomtask] / tests / todos.py
index 98c2aaf8da3e158f2709a4ef1f3251d63f7b9068..f33534d2b199586a10fb6fd071343d6c3c2236e9 100644 (file)
@@ -11,14 +11,26 @@ from plomtask.exceptions import (NotFoundException, BadFormatException,
 class TestsWithDB(TestCaseWithDB):
     """Tests requiring DB, but not server setup."""
 
+    def setUp(self) -> None:
+        super().setUp()
+        self.day1 = Day('2024-01-01')
+        self.day1.save(self.db_conn)
+        self.day2 = Day('2024-01-02')
+        self.day2.save(self.db_conn)
+        self.proc = Process(None)
+        self.proc.save_without_steps(self.db_conn)
+        self.cond1 = Condition(None)
+        self.cond1.save(self.db_conn)
+        self.cond2 = Condition(None)
+        self.cond2.save(self.db_conn)
+
     def test_Todo_by_id(self) -> None:
         """Test creation and findability of Todos."""
-        day = Day('2024-01-01')
-        process = Process(None)
-        todo = Todo(None, process, False, day)
+        process_unsaved = Process(None)
+        todo = Todo(None, process_unsaved, False, self.day1)
         with self.assertRaises(NotFoundException):
             todo.save(self.db_conn)
-        process.save_without_steps(self.db_conn)
+        process_unsaved.save_without_steps(self.db_conn)
         todo.save(self.db_conn)
         self.assertEqual(Todo.by_id(self.db_conn, 1), todo)
         with self.assertRaises(NotFoundException):
@@ -28,121 +40,92 @@ class TestsWithDB(TestCaseWithDB):
 
     def test_Todo_by_date(self) -> None:
         """Test findability of Todos by date."""
-        day1 = Day('2024-01-01')
-        day2 = Day('2024-01-02')
-        process = Process(None)
-        process.save_without_steps(self.db_conn)
-        todo1 = Todo(None, process, False, day1)
-        todo1.save(self.db_conn)
-        todo2 = Todo(None, process, False, day1)
-        todo2.save(self.db_conn)
-        self.assertEqual(Todo.by_date(self.db_conn, day1.date), [todo1, todo2])
-        self.assertEqual(Todo.by_date(self.db_conn, day2.date), [])
+        t1 = Todo(None, self.proc, False, self.day1)
+        t1.save(self.db_conn)
+        t2 = Todo(None, self.proc, False, self.day1)
+        t2.save(self.db_conn)
+        self.assertEqual(Todo.by_date(self.db_conn, self.day1.date), [t1, t2])
+        self.assertEqual(Todo.by_date(self.db_conn, self.day2.date), [])
         self.assertEqual(Todo.by_date(self.db_conn, 'foo'), [])
 
     def test_Todo_from_process(self) -> None:
         """Test spawning of Todo attributes from Process."""
-        day = Day('2024-01-01')
-        process = Process(None)
-        c1 = Condition(None, False)
-        c1.save(self.db_conn)
-        assert c1.id_ is not None
-        c2 = Condition(None, True)
-        c2.save(self.db_conn)
-        assert c2.id_ is not None
-        process.set_conditions(self.db_conn, [c1.id_])
-        todo = Todo(None, process, False, day)
-        self.assertEqual(todo.conditions, [c1])
-        todo.set_conditions(self.db_conn, [c2.id_])
-        self.assertEqual(todo.conditions, [c2])
-        self.assertEqual(process.conditions, [c1])
-        process.set_fulfills(self.db_conn, [c1.id_])
-        todo = Todo(None, process, False, day)
-        self.assertEqual(todo.fulfills, [c1])
-        todo.set_fulfills(self.db_conn, [c2.id_])
-        self.assertEqual(todo.fulfills, [c2])
-        self.assertEqual(process.fulfills, [c1])
-        process.set_undoes(self.db_conn, [c1.id_])
-        todo = Todo(None, process, False, day)
-        self.assertEqual(todo.undoes, [c1])
-        todo.set_undoes(self.db_conn, [c2.id_])
-        self.assertEqual(todo.undoes, [c2])
-        self.assertEqual(process.undoes, [c1])
+        assert self.cond1.id_ is not None
+        assert self.cond2.id_ is not None
+        self.proc.set_conditions(self.db_conn, [self.cond1.id_])
+        todo = Todo(None, self.proc, False, self.day1)
+        self.assertEqual(todo.conditions, [self.cond1])
+        todo.set_conditions(self.db_conn, [self.cond2.id_])
+        self.assertEqual(todo.conditions, [self.cond2])
+        self.assertEqual(self.proc.conditions, [self.cond1])
+        self.proc.set_fulfills(self.db_conn, [self.cond1.id_])
+        todo = Todo(None, self.proc, False, self.day1)
+        self.assertEqual(todo.fulfills, [self.cond1])
+        todo.set_fulfills(self.db_conn, [self.cond2.id_])
+        self.assertEqual(todo.fulfills, [self.cond2])
+        self.assertEqual(self.proc.fulfills, [self.cond1])
+        self.proc.set_undoes(self.db_conn, [self.cond1.id_])
+        todo = Todo(None, self.proc, False, self.day1)
+        self.assertEqual(todo.undoes, [self.cond1])
+        todo.set_undoes(self.db_conn, [self.cond2.id_])
+        self.assertEqual(todo.undoes, [self.cond2])
+        self.assertEqual(self.proc.undoes, [self.cond1])
 
     def test_Todo_on_conditions(self) -> None:
         """Test effect of Todos on Conditions."""
-        day = Day('2024-01-01')
-        process = Process(None)
-        process.save_without_steps(self.db_conn)
-        c1 = Condition(None, False)
-        c2 = Condition(None, True)
-        c1.save(self.db_conn)
-        c2.save(self.db_conn)
-        assert c1.id_ is not None
-        assert c2.id_ is not None
-        todo = Todo(None, process, False, day)
+        assert self.cond1.id_ is not None
+        assert self.cond2.id_ is not None
+        todo = Todo(None, self.proc, False, self.day1)
         todo.save(self.db_conn)
-        todo.set_fulfills(self.db_conn, [c1.id_])
-        todo.set_undoes(self.db_conn, [c2.id_])
+        todo.set_fulfills(self.db_conn, [self.cond1.id_])
+        todo.set_undoes(self.db_conn, [self.cond2.id_])
         todo.is_done = True
-        self.assertEqual(c1.is_active, True)
-        self.assertEqual(c2.is_active, False)
+        self.assertEqual(self.cond1.is_active, True)
+        self.assertEqual(self.cond2.is_active, False)
         todo.is_done = False
-        self.assertEqual(c1.is_active, True)
-        self.assertEqual(c2.is_active, False)
+        self.assertEqual(self.cond1.is_active, True)
+        self.assertEqual(self.cond2.is_active, False)
 
     def test_Todo_enablers_disablers(self) -> None:
         """Test Todo.enablers_for_at/disablers_for_at."""
-        day1 = Day('2024-01-01')
-        day2 = Day('2024-01-02')
-        process = Process(None)
-        process.save_without_steps(self.db_conn)
-        c1 = Condition(None, False)
-        c2 = Condition(None, True)
-        c1.save(self.db_conn)
-        c2.save(self.db_conn)
-        todo1 = Todo(None, process, False, day1)
+        assert self.cond1.id_ is not None
+        assert self.cond2.id_ is not None
+        todo1 = Todo(None, self.proc, False, self.day1)
         todo1.save(self.db_conn)
-        assert c1.id_ is not None
-        assert c2.id_ is not None
-        todo1.set_fulfills(self.db_conn, [c1.id_])
-        todo1.set_undoes(self.db_conn, [c2.id_])
+        todo1.set_fulfills(self.db_conn, [self.cond1.id_])
+        todo1.set_undoes(self.db_conn, [self.cond2.id_])
         todo1.save(self.db_conn)
-        assert todo1.id_ is not None
-        todo2 = Todo(None, process, False, day1)
+        todo2 = Todo(None, self.proc, False, self.day1)
         todo2.save(self.db_conn)
-        assert todo2.id_ is not None
-        todo2.set_fulfills(self.db_conn, [c2.id_])
+        todo2.set_fulfills(self.db_conn, [self.cond2.id_])
         todo2.save(self.db_conn)
-        todo3 = Todo(None, process, False, day2)
+        todo3 = Todo(None, self.proc, False, self.day2)
         todo3.save(self.db_conn)
-        assert todo3.id_ is not None
-        todo3.set_fulfills(self.db_conn, [c2.id_])
+        todo3.set_fulfills(self.db_conn, [self.cond2.id_])
         todo3.save(self.db_conn)
-        self.assertEqual(Todo.enablers_for_at(self.db_conn, c1, day1.date),
-                         [todo1])
-        self.assertEqual(Todo.enablers_for_at(self.db_conn, c1, day2.date),
-                         [])
-        self.assertEqual(Todo.disablers_for_at(self.db_conn, c1, day1.date),
-                         [])
-        self.assertEqual(Todo.disablers_for_at(self.db_conn, c1, day2.date),
-                         [])
-        self.assertEqual(Todo.enablers_for_at(self.db_conn, c2, day1.date),
-                         [todo2])
-        self.assertEqual(Todo.enablers_for_at(self.db_conn, c2, day2.date),
-                         [todo3])
-        self.assertEqual(Todo.disablers_for_at(self.db_conn, c2, day1.date),
-                         [todo1])
-        self.assertEqual(Todo.disablers_for_at(self.db_conn, c2, day2.date),
-                         [])
+        date1 = self.day1.date
+        date2 = self.day2.date
+        enablers = Todo.enablers_for_at(self.db_conn, self.cond1, date1)
+        self.assertEqual(enablers, [todo1])
+        enablers = Todo.enablers_for_at(self.db_conn, self.cond1, date2)
+        self.assertEqual(enablers, [])
+        disablers = Todo.disablers_for_at(self.db_conn, self.cond1, date1)
+        self.assertEqual(disablers, [])
+        disablers = Todo.disablers_for_at(self.db_conn, self.cond1, date2)
+        self.assertEqual(disablers, [])
+        enablers = Todo.enablers_for_at(self.db_conn, self.cond2, date1)
+        self.assertEqual(enablers, [todo2])
+        enablers = Todo.enablers_for_at(self.db_conn, self.cond2, date2)
+        self.assertEqual(enablers, [todo3])
+        disablers = Todo.disablers_for_at(self.db_conn, self.cond2, date1)
+        self.assertEqual(disablers, [todo1])
+        disablers = Todo.disablers_for_at(self.db_conn, self.cond2, date2)
+        self.assertEqual(disablers, [])
 
     def test_Todo_children(self) -> None:
         """Test Todo.children relations."""
-        day = Day('2024-01-01')
-        process = Process(None)
-        process.save_without_steps(self.db_conn)
-        todo_1 = Todo(None, process, False, day)
-        todo_2 = Todo(None, process, False, day)
+        todo_1 = Todo(None, self.proc, False, self.day1)
+        todo_2 = Todo(None, self.proc, False, self.day1)
         with self.assertRaises(HandledException):
             todo_1.add_child(todo_2)
         todo_1.save(self.db_conn)
@@ -158,12 +141,10 @@ class TestsWithDB(TestCaseWithDB):
 
     def test_Todo_conditioning(self) -> None:
         """Test Todo.doability conditions."""
-        day = Day('2024-01-01')
-        process = Process(None)
-        process.save_without_steps(self.db_conn)
-        todo_1 = Todo(None, process, False, day)
+        assert self.cond1.id_ is not None
+        todo_1 = Todo(None, self.proc, False, self.day1)
         todo_1.save(self.db_conn)
-        todo_2 = Todo(None, process, False, day)
+        todo_2 = Todo(None, self.proc, False, self.day1)
         todo_2.save(self.db_conn)
         todo_2.add_child(todo_1)
         with self.assertRaises(BadFormatException):
@@ -171,27 +152,20 @@ class TestsWithDB(TestCaseWithDB):
         todo_1.is_done = True
         todo_2.is_done = True
         todo_2.is_done = False
-        condition = Condition(None)
-        condition.save(self.db_conn)
-        assert condition.id_ is not None
-        todo_2.set_conditions(self.db_conn, [condition.id_])
+        todo_2.set_conditions(self.db_conn, [self.cond1.id_])
         with self.assertRaises(BadFormatException):
             todo_2.is_done = True
-        condition.is_active = True
+        self.cond1.is_active = True
         todo_2.is_done = True
 
     def test_Todo_singularity(self) -> None:
         """Test pointers made for single object keep pointing to it."""
-        day = Day('2024-01-01')
-        day.save(self.db_conn)
-        process = Process(None)
-        process.save_without_steps(self.db_conn)
-        todo = Todo(None, process, False, day)
+        todo = Todo(None, self.proc, False, self.day1)
         todo.save(self.db_conn)
         retrieved_todo = Todo.by_id(self.db_conn, 1)
         todo.is_done = True
         self.assertEqual(retrieved_todo.is_done, True)
-        retrieved_todo = Todo.by_date(self.db_conn, '2024-01-01')[0]
+        retrieved_todo = Todo.by_date(self.db_conn, self.day1.date)[0]
         retrieved_todo.is_done = False
         self.assertEqual(todo.is_done, False)
 
@@ -204,25 +178,25 @@ class TestsWithServer(TestCaseWithServer):
         form_data = {'title': '', 'description': '', 'effort': 1}
         self.check_post(form_data, '/process?id=', 302, '/')
         self.check_post(form_data, '/process?id=', 302, '/')
-        process1 = Process.by_id(self.db_conn, 1)
-        process2 = Process.by_id(self.db_conn, 2)
+        proc = Process.by_id(self.db_conn, 1)
+        proc2 = Process.by_id(self.db_conn, 2)
         form_data = {'comment': ''}
         self.check_post(form_data, '/day?date=2024-01-01', 302, '/')
         self.assertEqual(Todo.by_date(self.db_conn, '2024-01-01'), [])
-        form_data['new_todo'] = str(process1.id_)
+        form_data['new_todo'] = str(proc.id_)
         self.check_post(form_data, '/day?date=2024-01-01', 302, '/')
         todos = Todo.by_date(self.db_conn, '2024-01-01')
         self.assertEqual(1, len(todos))
         todo1 = todos[0]
         self.assertEqual(todo1.id_, 1)
-        self.assertEqual(todo1.process.id_, process1.id_)
+        self.assertEqual(todo1.process.id_, proc.id_)
         self.assertEqual(todo1.is_done, False)
-        form_data['new_todo'] = str(process2.id_)
+        form_data['new_todo'] = str(proc2.id_)
         self.check_post(form_data, '/day?date=2024-01-01', 302, '/')
         todos = Todo.by_date(self.db_conn, '2024-01-01')
         todo1 = todos[1]
         self.assertEqual(todo1.id_, 2)
-        self.assertEqual(todo1.process.id_, process2.id_)
+        self.assertEqual(todo1.process.id_, proc2.id_)
         self.assertEqual(todo1.is_done, False)
 
     def test_do_POST_todo(self) -> None: