Improve __eq__ of BaseModel to compare all saved attributes; plus minor refactorings.

[plomtask] / plomtask / conditions.py

diff --git a/plomtask/conditions.py b/plomtask/conditions.py
index 66961256e28ad2843ae9d72ba9babbbd552b6f60..45aa62b9b27a026c75549aea3350640c419d8a5e 100644 (file)
--- a/plomtask/conditions.py
+++ b/plomtask/conditions.py
@@ -4,10 +4,11 @@ from typing import Any
 from sqlite3 import Row
 from plomtask.db import DatabaseConnection, BaseModel
 from plomtask.misc import VersionedAttribute
+from plomtask.exceptions import HandledException
 
 
 class Condition(BaseModel[int]):
-    """Non Process-dependency for ProcessSteps and Todos."""
+    """Non-Process dependency for ProcessSteps and Todos."""
     table_name = 'conditions'
     to_save = ['is_active']
 
@@ -35,6 +36,18 @@ class Condition(BaseModel[int]):
         self.title.save(db_conn)
         self.description.save(db_conn)
 
+    def remove(self, db_conn: DatabaseConnection) -> None:
+        """Remove from DB, with dependencies."""
+        assert isinstance(self.id_, int)
+        for item in ('process', 'todo'):
+            for attr in ('conditions', 'enables', 'disables'):
+                table_name = f'{item}_{attr}'
+                for _ in db_conn.row_where(table_name, 'condition', self.id_):
+                    raise HandledException('cannot remove Condition in use')
+        db_conn.delete_where('condition_titles', 'parent', self.id_)
+        db_conn.delete_where('condition_descriptions', 'parent', self.id_)
+        super().remove(db_conn)
+
 
 class ConditionsRelations:
     """Methods for handling relations to Conditions, for Todo and Process."""