In save_game(), check for error return code of fclose(), too.

[plomrogue] / src / misc.c

diff --git a/src/misc.c b/src/misc.c
index ec05accaa513ac3ba8389f6020f1c5bb96e61924..cf69c8a8ecc91b7813c50d0585c10124b91e8c81 100644 (file)
--- a/src/misc.c
+++ b/src/misc.c
@@ -3,6 +3,7 @@
 #include "misc.h"
 #include <stdlib.h> /* for calloc(), free() */
 #include <string.h> /* for strlen(), strcmp(), memcpy() */
+#include <stdint.h> /* for uint8_t */
 #include "windows.h" /* for suspend_win(), append_win(), reset_pad_offset(),
                       * resize_active_win(), cycle_active_win(),
                       * shift_active_win(), struct Win, struct WinMeta
@@ -132,17 +133,21 @@ extern void turn_over(struct World * world, char action)
 
 extern void save_game(struct World * world)
 {
-    uint8_t fail;
+    char * err_msg = "Error saving game.";
+
     FILE * file = fopen("savefile", "w");
-    fail = write_uint32_bigendian(world->seed, file);
-    fail = fail | write_uint32_bigendian(world->turn, file);
-    fail = fail | write_uint16_bigendian(world->player->pos.y + 1, file);
-    fail = fail | write_uint16_bigendian(world->player->pos.x + 1, file);
-    fail = fail | write_uint8(world->player->hitpoints, file);
-    fail = fail | write_map_objects(world, world->monster, file);
-    fail = fail | write_map_objects(world, world->item, file);
-    exit_err(fail, world, "Error saving game.");
-    fclose(file);
+    exit_err(0 == file, world, err_msg);
+
+    uint8_t err;
+    err = write_uint32_bigendian(world->seed, file);
+    err = err | write_uint32_bigendian(world->turn, file);
+    err = err | write_uint16_bigendian(world->player->pos.y + 1, file);
+    err = err | write_uint16_bigendian(world->player->pos.x + 1, file);
+    err = err | write_uint8(world->player->hitpoints, file);
+    err = err | write_map_objects(world, world->monster, file);
+    err = err | write_map_objects(world, world->item, file);
+    exit_err(err, world, err_msg);
+    exit_err(fclose(file), world, err_msg);
 }
 
 
@@ -215,12 +220,10 @@ extern struct yx_uint16 find_passable_pos(struct Map * map)
 
 
 
-extern unsigned char meta_keys(int key, struct World * world,
-                               struct WinMeta * win_meta,
-                               struct Win * win_keys,
-                               struct Win * win_map,
-                               struct Win * win_info,
-                               struct Win * win_log)
+extern uint8_t meta_keys(int key, struct World * world,
+                         struct WinMeta * win_meta, struct Win * win_keys,
+                         struct Win * win_map, struct Win * win_info,
+                         struct Win * win_log)
 {
     if (key == get_action_key(world->keybindings, "quit"))
     {