Improve/extend automatic creation and adoption of Todos to fulfill ProcessSteps requi...

[plomtask] / tests / todos.py

diff --git a/tests/todos.py b/tests/todos.py
index 86986b6486ce6fe0ed75a34284daf57175de1d54..ecf2089a4b0544866004fdbb97521dbbc0b03fcf 100644 (file)
--- a/tests/todos.py
+++ b/tests/todos.py
@@ -154,11 +154,9 @@ class TestsWithDB(TestCaseWithDB):
         node_0.children += [node_4]
         self.assertEqual(todo_1.get_step_tree(set()), node_0)
 
-    def test_Todo_unsatisfied_steps(self) -> None:
-        """Test options of satisfying unfulfilled Process.explicit_steps."""
+    def test_Todo_create_with_children(self) -> None:
+        """Test parenthood guaranteeds of Todo.create_with_children."""
         assert isinstance(self.proc.id_, int)
-        todo_1 = Todo(None, self.proc, False, self.date1)
-        todo_1.save(self.db_conn)
         proc2 = Process(None)
         proc2.save(self.db_conn)
         assert isinstance(proc2.id_, int)
@@ -168,35 +166,30 @@ class TestsWithDB(TestCaseWithDB):
         proc4 = Process(None)
         proc4.save(self.db_conn)
         assert isinstance(proc4.id_, int)
+        # make proc4 step of proc3
         proc3.set_steps(self.db_conn, [(None, proc4.id_, None)])
+        # give proc2 three steps; 2× proc1, 1× proc3
         proc2.set_steps(self.db_conn, [(None, self.proc.id_, None),
                                        (None, self.proc.id_, None),
                                        (None, proc3.id_, None)])
-        todo_2 = Todo(None, proc2, False, self.date1)
-        todo_2.save(self.db_conn)
-        # test empty adoption does nothing
-        todo_2.adopt_from([])
-        self.assertEqual(todo_2.children, [])
-        # test basic adoption
-        todo_2.adopt_from([todo_1])
-        self.assertEqual(todo_2.children, [todo_1])
-        self.assertEqual(todo_1.parents, [todo_2])
-        # test making missing children
-        todo_2.make_missing_children(self.db_conn)
-        todo_3 = Todo.by_id(self.db_conn, 3)
-        todo_4 = Todo.by_id(self.db_conn, 4)
-        self.assertEqual(todo_2.children, [todo_1, todo_3, todo_4])
-        self.assertEqual(todo_3.process, self.proc)
-        self.assertEqual(todo_3.parents, [todo_2])
-        self.assertEqual(todo_3.children, [])
-        self.assertEqual(todo_4.process, proc3)
-        self.assertEqual(todo_4.parents, [todo_2])
-        # test .make_missing_children lower down the tree
-        todo_4.make_missing_children(self.db_conn)
-        todo_5 = Todo.by_id(self.db_conn, 5)
-        self.assertEqual(todo_5.process, proc4)
-        self.assertEqual(todo_4.children, [todo_5])
-        self.assertEqual(todo_5.parents, [todo_4])
+        # test mere creation does nothing
+        todo_ignore = Todo(None, proc2, False, self.date1)
+        todo_ignore.save(self.db_conn)
+        self.assertEqual(todo_ignore.children, [])
+        # test create_with_children on step-less does nothing
+        todo_1 = Todo.create_with_children(self.db_conn, self.proc.id_,
+                                           self.date1)
+        self.assertEqual(todo_1.children, [])
+        self.assertEqual(len(Todo.all(self.db_conn)), 2)
+        # test create_with_children adopts and creates, and down tree too
+        todo_2 = Todo.create_with_children(self.db_conn, proc2.id_, self.date1)
+        self.assertEqual(3, len(todo_2.children))
+        self.assertEqual(todo_1, todo_2.children[0])
+        self.assertEqual(self.proc, todo_2.children[1].process)
+        self.assertEqual(proc3, todo_2.children[2].process)
+        todo_3 = todo_2.children[2]
+        self.assertEqual(len(todo_3.children), 1)
+        self.assertEqual(todo_3.children[0].process, proc4)
 
     def test_Todo_singularity(self) -> None:
         """Test pointers made for single object keep pointing to it."""
@@ -353,8 +346,8 @@ class TestsWithServer(TestCaseWithServer):
             assert isinstance(t.process.id_, int)
             return t.process.id_
 
-        def check_adoption(date: str, new_todo: list[int]) -> None:
-            form_data = {'day_comment': '', 'new_todo': new_todo}
+        def check_adoption(date: str, new_todos: list[int]) -> None:
+            form_data = {'day_comment': '', 'new_todo': new_todos}
             self.check_post(form_data, f'/day?date={date}', 302)
             day_todos = Todo.by_date(self.db_conn, date)
             day_todos.sort(key=key_order_func)
@@ -367,7 +360,6 @@ class TestsWithServer(TestCaseWithServer):
 
         def check_nesting_adoption(process_id: int, date: str,
                                    new_top_steps: list[int]) -> None:
-            result_reversed = new_top_steps[1] < new_top_steps[0]
             form_data = self.post_process()
             form_data = self.post_process(process_id,
                                           form_data |
@@ -380,15 +372,12 @@ class TestsWithServer(TestCaseWithServer):
             todo1 = day_todos[0]  # process of process_id
             todo2 = day_todos[1]  # process 2
             todo3 = day_todos[2]  # process 1
-            if result_reversed:
-                self.assertEqual(todo1.children, [todo2, todo3])
-            else:
-                self.assertEqual(todo1.children, [todo3, todo2])
+            self.assertEqual(sorted(todo1.children), sorted([todo2, todo3]))
             self.assertEqual(todo1.parents, [])
             self.assertEqual(todo2.children, [todo3])
             self.assertEqual(todo2.parents, [todo1])
             self.assertEqual(todo3.children, [])
-            self.assertEqual(todo3.parents, [todo2, todo1])
+            self.assertEqual(sorted(todo3.parents), sorted([todo2, todo1]))
 
         form_data = self.post_process()
         form_data = self.post_process(2, form_data | {'new_top_step': 1})