Fix pylint E0606 warnings.

diff --git a/bookmaker.py b/bookmaker.py
index 73ab49d1f6a7cd9990810498d913a3bf9e290b44..21d4e754de84bdd4fe32a11d01f571816126b0eb 100755 (executable)
--- a/bookmaker.py
+++ b/bookmaker.py
@@ -502,10 +502,10 @@ def build_nup4_output(
     nup4_i = 0
     page_count = 0
     is_front_page = True
     nup4_i = 0
     page_count = 0
     is_front_page = True

+    new_page: Optional[PdfPage] = None

     for i, page in enumerate(pages_to_add):
     for i, page in enumerate(pages_to_add):

-        if nup4_i == 0:
-            new_page = PdfPage.create_blank_page(
-                    width=A4_WIDTH, height=A4_HEIGHT)
+        new_page = new_page or PdfPage.create_blank_page(width=A4_WIDTH,
+                                                         height=A4_HEIGHT)

         corrected_i = old_indices[i]
         nup4_inner_page_transform(
                 page, page_croppings[corrected_i], nup4_geometry, nup4_i)
         corrected_i = old_indices[i]
         nup4_inner_page_transform(
                 page, page_croppings[corrected_i], nup4_geometry, nup4_i)


@@ -521,6 +521,7 @@ def build_nup4_output(
                         nup4_geometry)
             writer.add_page(new_page)
             nup4_i = 0
                         nup4_geometry)
             writer.add_page(new_page)
             nup4_i = 0

+            new_page = None

             is_front_page = not is_front_page
 
 
             is_front_page = not is_front_page
 
 


@@ -582,7 +583,7 @@ def nup4_outer_page_transform(
         y_section = A4_HEIGHT
         page.mediabox.bottom = A4_HALF_HEIGHT
         page.mediabox.top = A4_HEIGHT
         y_section = A4_HEIGHT
         page.mediabox.bottom = A4_HALF_HEIGHT
         page.mediabox.top = A4_HEIGHT

-    if nup4_i in {2, 3}:
+    else:  # nup4_in in {2, 3}

         y_section = 0
         page.mediabox.bottom = 0
         page.mediabox.top = A4_HALF_HEIGHT
         y_section = 0
         page.mediabox.bottom = 0
         page.mediabox.top = A4_HALF_HEIGHT


@@ -591,7 +592,7 @@ def nup4_outer_page_transform(
         x_section = 0
         page.mediabox.left = 0
         page.mediabox.right = A4_HALF_WIDTH
         x_section = 0
         page.mediabox.left = 0
         page.mediabox.right = A4_HALF_WIDTH

-    if nup4_i in {1, 3}:
+    else:  # nup4_in in {1, 3}

         page.add_transformation(PdfTransformation().translate(
             tx=(1-nup4_geometry.shrink_for_spine)*A4_WIDTH))
         x_section = A4_WIDTH
         page.add_transformation(PdfTransformation().translate(
             tx=(1-nup4_geometry.shrink_for_spine)*A4_WIDTH))
         x_section = A4_WIDTH