From: Christian Heller <c.heller@plomlompom.de>
Date: Sat, 24 Jan 2026 12:01:12 +0000 (+0100)
Subject: Fix _blocks_valid_up_incl not actually being "_incl".
X-Git-Url: https://plomlompom.com/repos/booking/%7B%7Bprefix%7D%7D/%7B%7B%20web_path%20%7D%7D/static/index.html?a=commitdiff_plain;h=5cfc676e8f8d6b9ae18d5671602fb7d1945c61fa;p=ledgplom

Fix _blocks_valid_up_incl not actually being "_incl".
---

diff --git a/src/ledgplom/ledger.py b/src/ledgplom/ledger.py
index 2706125..9af74cb 100644
--- a/src/ledgplom/ledger.py
+++ b/src/ledgplom/ledger.py
@@ -654,7 +654,7 @@ class Ledger:
 
     def _blocks_valid_up_incl(self, block_id: int) -> bool:
         'Whether nothing questionable about blocks until block_id.'
-        for block in self.blocks[:block_id]:
+        for block in self.blocks[:block_id + 1]:
             if block.booking:
                 if block.booking.sink_error:
                     return False
diff --git a/src/tests/full.balance b/src/tests/full.balance
index 4c70e1e..f68cfd4 100644
--- a/src/tests/full.balance
+++ b/src/tests/full.balance
@@ -92,7 +92,7 @@ span.indent {
                     <table>
                     <tbody>
                         <tr>
-                            <td class="balance amount">-18</td>
+                            <td class="balance amount">-19</td>
                             <td class="balance currency">€</td>
                         </tr>
                     </tbody>
diff --git a/src/tests/full.balance.4 b/src/tests/full.balance.4
index c48034a..6785650 100644
--- a/src/tests/full.balance.4
+++ b/src/tests/full.balance.4
@@ -83,7 +83,7 @@ span.indent {
     |
     balance after <a href="/blocks/4">booking 4 (2001-01-03: test)</a>
 </p>
-<table class="alternating critical">
+<table class="alternating ">
 <tbody>
     <tr>
         <td class="money">
@@ -92,7 +92,7 @@ span.indent {
                     <table>
                     <tbody>
                         <tr>
-                            <td class="balance amount">-9</td>
+                            <td class="balance amount">-10</td>
                             <td class="balance currency">€</td>
                         </tr>
                     </tbody>
diff --git a/src/tests/full.dat b/src/tests/full.dat
index 2bb5747..080eec2 100644
--- a/src/tests/full.dat
+++ b/src/tests/full.dat
@@ -7,12 +7,10 @@
 2001-01-02 test
     bar   -10 €  ; bar
     baz    10 €
-    baz     x €
 
 
 2001-01-02 test
     bar    20 €
-    bar     1 €
     baz   -20 €  ; baz
 
 2001-01-03 test
diff --git a/src/tests/full.edit_raw.4 b/src/tests/full.edit_raw.4
index c49bb94..158fa53 100644
--- a/src/tests/full.edit_raw.4
+++ b/src/tests/full.edit_raw.4
@@ -90,7 +90,7 @@ td.direct_target {
 
 </textarea>
 </form>
-<table class="alternating critical">
+<table class="alternating">
 <tbody>
     <tr>
         <th>account</th>
@@ -104,7 +104,7 @@ td.direct_target {
             <table>
             <tbody>
                 <tr>
-                    <td class="balance amount">1</td>
+                    <td class="balance amount">0</td>
                     <td class="balance currency">€</td>
                 </tr>
                 <tr>
@@ -132,7 +132,7 @@ td.direct_target {
             <table>
             <tbody>
                 <tr>
-                    <td class="balance amount">-9</td>
+                    <td class="balance amount">-10</td>
                     <td class="balance currency">€</td>
                 </tr>
                 <tr>
diff --git a/src/tests/full.edit_structured.4 b/src/tests/full.edit_structured.4
index 2445a52..46e97f6 100644
--- a/src/tests/full.edit_structured.4
+++ b/src/tests/full.edit_structured.4
@@ -221,7 +221,7 @@ to
 <option value="foo:x">foo:x</option>
 </datalist>
 <hr>
-<table class="alternating critical">
+<table class="alternating">
 <tbody>
     <tr>
         <th>account</th>
@@ -235,7 +235,7 @@ to
             <table>
             <tbody>
                 <tr>
-                    <td class="balance amount">1</td>
+                    <td class="balance amount">0</td>
                     <td class="balance currency">€</td>
                 </tr>
                 <tr>
@@ -263,7 +263,7 @@ to
             <table>
             <tbody>
                 <tr>
-                    <td class="balance amount">-9</td>
+                    <td class="balance amount">-10</td>
                     <td class="balance currency">€</td>
                 </tr>
                 <tr>
diff --git a/src/tests/full.edit_structured.5 b/src/tests/full.edit_structured.5
index 9a11c67..9488d59 100644
--- a/src/tests/full.edit_structured.5
+++ b/src/tests/full.edit_structured.5
@@ -241,7 +241,7 @@ to
             <table>
             <tbody>
                 <tr>
-                    <td class="balance amount">-9</td>
+                    <td class="balance amount">-10</td>
                     <td class="balance currency">€</td>
                 </tr>
                 <tr>
@@ -269,7 +269,7 @@ to
             <table>
             <tbody>
                 <tr>
-                    <td class="balance amount">-18</td>
+                    <td class="balance amount">-19</td>
                     <td class="balance currency">€</td>
                 </tr>
                 <tr>
diff --git a/src/tests/full.ledger_raw b/src/tests/full.ledger_raw
index 9d2d63a..89896b6 100644
--- a/src/tests/full.ledger_raw
+++ b/src/tests/full.ledger_raw
@@ -93,14 +93,14 @@ Detected redundant empty lines in gaps, <input type="submit" name="remove_redund
     <tr><td>&nbsp;</td></tr>
     <tr></tr><!-- keep the background-color alternation in proper order -->
     <tr id="block_2">
-        <td rowspan="7" class="block_column">
+        <td rowspan="6" class="block_column">
             <input type="submit" name="ledger_moveup_2" value="^" disabled="">
             <br>
             <input type="submit" name="ledger_movedown_2" value="v">
             <br>
             <input type="submit" name="ledger_copy_2" value="C">
         </td>
-        <td rowspan="7" class="block_column">
+        <td rowspan="6" class="block_column">
             [<a href="#block_2">#</a>]<br>
             [<a href="/balance/2">b</a>]<br>
             [<a href="/edit_raw/2">e</a>]
@@ -109,19 +109,18 @@ Detected redundant empty lines in gaps, <input type="submit" name="remove_redund
     <tr><td>2001-01-02 test&nbsp;</td></tr>
     <tr><td>  bar  -10 € ; bar&nbsp;</td></tr>
     <tr><td>  baz  10 €&nbsp;</td></tr>
-    <tr><td class="critical">  baz  x €&nbsp;</td></tr>
     <tr><td>&nbsp;</td></tr>
     <tr><td>&nbsp;</td></tr>
     <tr></tr><!-- keep the background-color alternation in proper order -->
     <tr id="block_3">
-        <td rowspan="6" class="block_column">
+        <td rowspan="5" class="block_column">
             <input type="submit" name="ledger_moveup_3" value="^">
             <br>
             <input type="submit" name="ledger_movedown_3" value="v" disabled="">
             <br>
             <input type="submit" name="ledger_copy_3" value="C">
         </td>
-        <td rowspan="6" class="block_column critical">
+        <td rowspan="5" class="block_column">
             [<a href="#block_3">#</a>]<br>
             [<a href="/balance/3">b</a>]<br>
             [<a href="/edit_raw/3">e</a>]
@@ -129,7 +128,6 @@ Detected redundant empty lines in gaps, <input type="submit" name="remove_redund
     </tr>
     <tr><td>2001-01-02 test&nbsp;</td></tr>
     <tr><td>  bar  20 €&nbsp;</td></tr>
-    <tr><td>  bar  1 €&nbsp;</td></tr>
     <tr><td>  baz  -20 € ; baz&nbsp;</td></tr>
     <tr><td>&nbsp;</td></tr>
     <tr></tr><!-- keep the background-color alternation in proper order -->
diff --git a/src/tests/full.ledger_structured b/src/tests/full.ledger_structured
index 457dbbe..cf0ea78 100644
--- a/src/tests/full.ledger_structured
+++ b/src/tests/full.ledger_structured
@@ -117,14 +117,14 @@ Detected redundant empty lines in gaps, <input type="submit" name="remove_redund
     </tr>
     <tr></tr><!-- keep the background-color alternation in proper order -->
     <tr id="block_2">
-        <td rowspan="7" class="block_column">
+        <td rowspan="6" class="block_column">
             <input type="submit" name="ledger_moveup_2" value="^" disabled="">
             <br>
             <input type="submit" name="ledger_movedown_2" value="v">
             <br>
             <input type="submit" name="ledger_copy_2" value="C">
         </td>
-        <td rowspan="7" class="block_column">
+        <td rowspan="6" class="block_column">
             [<a href="#block_2">#</a>]<br>
             [<a href="/balance/2">b</a>]<br>
             [<a href="/edit_structured/2">e</a>]
@@ -146,12 +146,6 @@ Detected redundant empty lines in gaps, <input type="submit" name="remove_redund
         <td>baz</td>
         <td></td>
     </tr>
-    <tr>
-        <td class="amount critical">x</td>
-        <td class="currency critical">€</td>
-        <td class="critical">baz</td>
-        <td></td>
-    </tr>
     <tr>
         <td colspan="4">&nbsp;</td>
     </tr>
@@ -160,14 +154,14 @@ Detected redundant empty lines in gaps, <input type="submit" name="remove_redund
     </tr>
     <tr></tr><!-- keep the background-color alternation in proper order -->
     <tr id="block_3">
-        <td rowspan="6" class="block_column">
+        <td rowspan="5" class="block_column">
             <input type="submit" name="ledger_moveup_3" value="^">
             <br>
             <input type="submit" name="ledger_movedown_3" value="v" disabled="">
             <br>
             <input type="submit" name="ledger_copy_3" value="C">
         </td>
-        <td rowspan="6" class="block_column critical">
+        <td rowspan="5" class="block_column">
             [<a href="#block_3">#</a>]<br>
             [<a href="/balance/3">b</a>]<br>
             [<a href="/edit_structured/3">e</a>]
@@ -183,12 +177,6 @@ Detected redundant empty lines in gaps, <input type="submit" name="remove_redund
         <td>bar</td>
         <td></td>
     </tr>
-    <tr>
-        <td class="amount">1.00</td>
-        <td class="currency">€</td>
-        <td>bar</td>
-        <td></td>
-    </tr>
     <tr>
         <td class="amount">-20.00</td>
         <td class="currency">€</td>