X-Git-Url: https://plomlompom.com/repos/feed.xml?a=blobdiff_plain;f=plomrogue%2Fmapping.py;h=e3c071f85251ae9e947183a474fe69d78294e2bf;hb=aab94ffb12aa0dedc240d7b29001699b95c49249;hp=e806ef70f8c721386bf9cdeada5733fc57eea176;hpb=31951696faf591c6d92236c70a9637c7620111e5;p=plomrogue2

diff --git a/plomrogue/mapping.py b/plomrogue/mapping.py
index e806ef7..e3c071f 100644
--- a/plomrogue/mapping.py
+++ b/plomrogue/mapping.py
@@ -21,6 +21,7 @@ class MapGeometry():
     def __init__(self, size):
         self.size = size
         self.neighbors_i = {}
+        self.directions = self.get_directions()
 
     def get_directions(self):
         directions = []
@@ -32,13 +33,13 @@ class MapGeometry():
 
     def get_neighbors_yxyx(self, yxyx):
         neighbors = {}
-        for direction in self.get_directions():
+        for direction in self.directions:
             neighbors[direction] = self.move_yxyx(yxyx, direction)
         return neighbors
 
     def get_neighbors_yx(self, pos):
         neighbors = {}
-        for direction in self.get_directions():
+        for direction in self.directions:
             neighbors[direction] = self.move_yx(pos, direction)
         return neighbors
 
@@ -164,7 +165,7 @@ class Map():
 
     def __init__(self, map_geometry):
         self.geometry = map_geometry
-        self.terrain = '.' * self.size_i
+        self.terrain = '.' * self.size_i  # TODO: use Game.get_flatland()?
 
     def __getitem__(self, yx):
         return self.terrain[self.get_position_index(yx)]
@@ -209,7 +210,9 @@ class Map():
 
 class SourcedMap(Map):
 
-    def __init__(self, things, source_maps, source_center, radius, get_map):
+    def __init__(self, block_chars, things, source_maps, source_center, radius,
+                 get_map):
+        self.block_chars = block_chars
         self.radius = radius
         example_map = get_map(YX(0, 0))
         self.source_geometry = example_map.geometry
@@ -227,10 +230,10 @@ class SourcedMap(Map):
             if yxyx[0] not in obstacles:
                 obstacles[yxyx[0]] = []
             obstacles[yxyx[0]] += [yxyx[1]]
-        for yx in self:
+        for yx in self:  # TODO: iter and source_yxyx expensive, cache earlier?
             big_yx, little_yx = self.source_yxyx(yx)
             if big_yx in obstacles and little_yx in obstacles[big_yx]:
-                self.source_map_segment += 'X'
+                self.source_map_segment += self.block_chars[0]
             else:
                 self.source_map_segment += source_maps[big_yx][little_yx]
 
@@ -256,6 +259,12 @@ class SourcedMap(Map):
 class DijkstraMap(SourcedMap):
 
     def __init__(self, *args, **kwargs):
+        # TODO: check potential optimizations:
+        # - do a first pass circling out from the center
+        # - somehow ignore tiles that have the lowest possible value (we can
+        #   compare with a precalculated map for given starting position)
+        # - check if Python offers more efficient data structures to use here
+        # - shorten radius to nearest possible target
         super().__init__(*args, **kwargs)
         self.terrain = [255] * self.size_i
         self[self.center] = 0
@@ -263,7 +272,7 @@ class DijkstraMap(SourcedMap):
         while shrunk:
             shrunk = False
             for i in range(self.size_i):
-                if self.source_map_segment[i] in 'X=':
+                if self.source_map_segment[i] in self.block_chars:
                     continue
                 neighbors = self.geometry.get_neighbors_i(i)
                 for direction in [d for d in neighbors if neighbors[d]]:
@@ -303,7 +312,8 @@ class FovMap(SourcedMap):
         return self
 
     def throws_shadow(self, yx):
-        return self.source_map_segment[self.get_position_index(yx)] == 'X'
+        return self.source_map_segment[self.get_position_index(yx)]\
+            in self.block_chars
 
     def shadow_process(self, yx, distance_to_center, dir_i, dir_progress):
         # Possible optimization: If no shadow_cones yet and self[yx] == '.',
@@ -370,8 +380,7 @@ class FovMap(SourcedMap):
         return mover(pos)
 
     def circle_out(self, yx, f):
-        # Optimization potential: Precalculate movement positions. (How to check
-        # circle_in_map then?)
+        # Optimization potential: Precalculate movement positions.
         # Optimization potential: Precalculate what tiles are shaded by what tile
         # and skip evaluation of already shaded tile. (This only works if tiles
         # shading implies they completely lie in existing shades; otherwise we