X-Git-Url: https://plomlompom.com/repos/feed.xml?a=blobdiff_plain;f=plomtask%2Fconditions.py;h=a6e9c97c6bdc05acf654ecda21317df1fbe04e85;hb=e60bbd142b5026748ee2181ca6758afef6202fb4;hp=337970924ab25305d64abef13afe24148b0209b1;hpb=23012cd370777b60a25839788d131173d2abee91;p=plomtask diff --git a/plomtask/conditions.py b/plomtask/conditions.py index 3379709..a6e9c97 100644 --- a/plomtask/conditions.py +++ b/plomtask/conditions.py @@ -3,7 +3,7 @@ from __future__ import annotations from typing import Any from sqlite3 import Row from plomtask.db import DatabaseConnection, BaseModel -from plomtask.misc import VersionedAttribute +from plomtask.versioned_attributes import VersionedAttribute from plomtask.exceptions import HandledException @@ -11,6 +11,7 @@ class Condition(BaseModel[int]): """Non-Process dependency for ProcessSteps and Todos.""" table_name = 'conditions' to_save = ['is_active'] + to_save_versioned = ['title', 'description'] def __init__(self, id_: int | None, is_active: bool = False) -> None: super().__init__(id_) @@ -30,15 +31,14 @@ class Condition(BaseModel[int]): getattr(condition, name).history_from_row(row_) return condition - def save(self, db_conn: DatabaseConnection) -> None: - """Save self and its VersionedAttributes to DB and cache.""" - self.save_core(db_conn) - self.title.save(db_conn) - self.description.save(db_conn) - def remove(self, db_conn: DatabaseConnection) -> None: - """Remove from DB, with dependencies.""" - assert isinstance(self.id_, int) + """Remove from DB, with VersionedAttributes. + + Checks for Todos and Processes that depend on Condition, prohibits + deletion if found. + """ + if self.id_ is None: + raise HandledException('cannot remove unsaved item') for item in ('process', 'todo'): for attr in ('conditions', 'enables', 'disables'): table_name = f'{item}_{attr}'