X-Git-Url: https://plomlompom.com/repos/feed.xml?a=blobdiff_plain;f=tests%2Fprocesses.py;h=bda62750442501445fae1883f9a8a2b280aa18f8;hb=d77d0661697655a7c2d0e9e0b270cf21e286d7fb;hp=8a7f91d4c561a34878af14b7e0796dcaa38ecf26;hpb=8bbb9ac156bdca7b9dd015b62db3f07f1e7a9e17;p=plomtask diff --git a/tests/processes.py b/tests/processes.py index 8a7f91d..bda6275 100644 --- a/tests/processes.py +++ b/tests/processes.py @@ -1,7 +1,8 @@ """Test Processes module.""" from unittest import TestCase +from typing import Any from tests.utils import TestCaseWithDB, TestCaseWithServer -from plomtask.processes import Process +from plomtask.processes import Process, ProcessStep from plomtask.exceptions import NotFoundException, BadFormatException @@ -14,28 +15,83 @@ class TestsSansDB(TestCase): self.assertEqual(Process(None).description.newest, '') self.assertEqual(Process(None).effort.newest, 1.0) + def test_Process_legal_ID(self) -> None: + """Test Process cannot be instantiated with id_=0.""" + with self.assertRaises(BadFormatException): + Process(0) + class TestsWithDB(TestCaseWithDB): """Mdule tests not requiring DB setup.""" - def test_Process_save(self) -> None: - """Test Process.save().""" - p_saved = Process(None) - p_saved.save(self.db_conn) - self.assertEqual(p_saved.id_, + def test_Process_ids(self) -> None: + """Test Process.save_without_steps() re Process.id_.""" + p = Process(None) + p.save_without_steps(self.db_conn) + self.assertEqual(p.id_, Process.by_id(self.db_conn, 1, create=False).id_) - with self.assertRaises(BadFormatException): - p_saved = Process(0) - p_saved = Process(5) - p_saved.save(self.db_conn) - self.assertEqual(p_saved.id_, + p = Process(None) + p.save_without_steps(self.db_conn) + self.assertEqual(p.id_, + Process.by_id(self.db_conn, 2, create=False).id_) + p = Process(5) + p.save_without_steps(self.db_conn) + self.assertEqual(p.id_, Process.by_id(self.db_conn, 5, create=False).id_) - p_saved.title.set('named') - p_loaded = Process.by_id(self.db_conn, p_saved.id_) - self.assertNotEqual(p_saved.title.history, p_loaded.title.history) - p_saved.save(self.db_conn) - p_loaded = Process.by_id(self.db_conn, p_saved.id_) - self.assertEqual(p_saved.title.history, p_loaded.title.history) + + def test_Process_steps(self) -> None: + """Test addition, nesting, and non-recursion of ProcessSteps""" + p_1 = Process(1) + p_1.save_without_steps(self.db_conn) + assert p_1.id_ is not None + p_2 = Process(2) + p_2.save_without_steps(self.db_conn) + assert p_2.id_ is not None + p_3 = Process(3) + p_3.save_without_steps(self.db_conn) + assert p_3.id_ is not None + p_1.add_step(self.db_conn, None, p_2.id_, None) + p_1_dict: dict[int, dict[str, Any]] = {1: { + 'process': p_2, 'parent_id': None, + 'is_explicit': True, 'steps': {}, 'seen': False + }} + self.assertEqual(p_1.get_steps(self.db_conn, None), p_1_dict) + s_b = p_1.add_step(self.db_conn, None, p_3.id_, None) + p_1_dict[2] = { + 'process': p_3, 'parent_id': None, + 'is_explicit': True, 'steps': {}, 'seen': False + } + self.assertEqual(p_1.get_steps(self.db_conn, None), p_1_dict) + s_c = p_2.add_step(self.db_conn, None, p_3.id_, None) + assert s_c.id_ is not None + p_1_dict[1]['steps'] = {3: { + 'process': p_3, 'parent_id': None, + 'is_explicit': False, 'steps': {}, 'seen': False + }} + self.assertEqual(p_1.get_steps(self.db_conn, None), p_1_dict) + p_1.add_step(self.db_conn, None, p_2.id_, s_b.id_) + p_1_dict[2]['steps'][4] = { + 'process': p_2, 'parent_id': s_b.id_, 'seen': False, + 'is_explicit': True, 'steps': {3: { + 'process': p_3, 'parent_id': None, + 'is_explicit': False, 'steps': {}, 'seen': True + }}} + self.assertEqual(p_1.get_steps(self.db_conn, None), p_1_dict) + p_1.add_step(self.db_conn, None, p_3.id_, 999) + p_1_dict[5] = { + 'process': p_3, 'parent_id': None, + 'is_explicit': True, 'steps': {}, 'seen': False + } + self.assertEqual(p_1.get_steps(self.db_conn, None), p_1_dict) + p_1.add_step(self.db_conn, None, p_3.id_, 3) + p_1_dict[6] = { + 'process': p_3, 'parent_id': None, + 'is_explicit': True, 'steps': {}, 'seen': False + } + self.assertEqual(p_1.get_steps(self.db_conn, None), p_1_dict) + self.assertEqual(p_1.used_as_step_by(self.db_conn), []) + self.assertEqual(p_2.used_as_step_by(self.db_conn), [p_1]) + self.assertEqual(p_3.used_as_step_by(self.db_conn), [p_1, p_2]) def test_Process_by_id(self) -> None: """Test Process.by_id().""" @@ -55,32 +111,57 @@ class TestsWithDB(TestCaseWithDB): def test_Process_all(self) -> None: """Test Process.all().""" p_1 = Process(None) - p_1.save(self.db_conn) + p_1.save_without_steps(self.db_conn) p_2 = Process(None) - p_2.save(self.db_conn) + p_2.save_without_steps(self.db_conn) self.assertEqual({p_1.id_, p_2.id_}, set(p.id_ for p in Process.all(self.db_conn))) + def test_ProcessStep_singularity(self) -> None: + """Test pointers made for single object keep pointing to it.""" + p_1 = Process(None) + p_1.save_without_steps(self.db_conn) + p_2 = Process(None) + p_2.save_without_steps(self.db_conn) + assert p_2.id_ is not None + step = p_1.add_step(self.db_conn, None, p_2.id_, None) + assert step.id_ is not None + step_retrieved = ProcessStep.by_id(self.db_conn, step.id_) + step.parent_step_id = 99 + self.assertEqual(step.parent_step_id, step_retrieved.parent_step_id) + + def test_Process_singularity(self) -> None: + """Test pointers made for single object keep pointing to it.""" + p_1 = Process(None) + p_1.save_without_steps(self.db_conn) + p_2 = Process(None) + p_2.save_without_steps(self.db_conn) + assert p_2.id_ is not None + p_1.add_step(self.db_conn, None, p_2.id_, None) + p_retrieved = Process.by_id(self.db_conn, p_1.id_) + self.assertEqual(p_1.explicit_steps, p_retrieved.explicit_steps) + + def test_Process_versioned_attributes_singularity(self) -> None: + """Test behavior of VersionedAttributes on saving (with .title).""" + p = Process(None) + p.save_without_steps(self.db_conn) + p.title.set('named') + p_loaded = Process.by_id(self.db_conn, p.id_) + self.assertEqual(p.title.history, p_loaded.title.history) + class TestsWithServer(TestCaseWithServer): """Module tests against our HTTP server/handler (and database).""" def test_do_POST_process(self) -> None: """Test POST /process and its effect on the database.""" - form_data = {'title': 'foo', 'description': 'foo', - 'effort': 1.1, 'children': [1, 2]} + self.assertEqual(0, len(Process.all(self.db_conn))) + form_data = {'title': 'foo', 'description': 'foo', 'effort': 1.1} + self.check_post(form_data, '/process?id=', 302, '/') + self.assertEqual(1, len(Process.all(self.db_conn))) self.check_post(form_data, '/process?id=FOO', 400) form_data['effort'] = 'foo' self.check_post(form_data, '/process?id=', 400) - form_data['effort'] = 1.1 - form_data['children'] = 1.1 - self.check_post(form_data, '/process?id=', 400) - form_data['children'] = 'a' - self.check_post(form_data, '/process?id=', 400) - form_data['children'] = [1, 1.2] - self.check_post(form_data, '/process?id=', 400) - form_data['children'] = [1, 'b'] - self.check_post(form_data, '/process?id=', 400) self.check_post({}, '/process?id=', 400) form_data = {'title': '', 'description': ''} self.check_post(form_data, '/process?id=', 400) @@ -88,26 +169,7 @@ class TestsWithServer(TestCaseWithServer): self.check_post(form_data, '/process?id=', 400) form_data = {'description': '', 'effort': 1.0} self.check_post(form_data, '/process?id=', 400) - form_data = {'title': '', 'description': '', - 'effort': 1.1, 'children': [1, 2]} - self.check_post(form_data, '/process?id=', 302, '/') - retrieved_1 = Process.by_id(self.db_conn, 1) - self.assertEqual(retrieved_1.title.newest, '') - self.assertEqual(retrieved_1.child_ids, [1, 2]) - form_data['children'] = [] - self.check_post(form_data, '/process?id=', 302, '/') - retrieved_2 = Process.by_id(self.db_conn, 2) - self.assertEqual(retrieved_2.child_ids, []) - del form_data['children'] - self.check_post(form_data, '/process?id=', 302, '/') - retrieved_3 = Process.by_id(self.db_conn, 3) - self.assertEqual(retrieved_2.child_ids, []) - self.check_post(form_data, '/process?id=1', 302, '/') - self.assertEqual([p.id_ for p in Process.all(self.db_conn)], - [retrieved_1.id_, retrieved_2.id_, retrieved_3.id_]) - retrieved_1 = Process.by_id(self.db_conn, 1) - self.assertEqual(retrieved_1.child_ids, []) - self.check_post(form_data, '/process', 302, '/') + self.assertEqual(1, len(Process.all(self.db_conn))) def test_do_GET(self) -> None: """Test /process and /processes response codes."""