Minor refactoring.

[plomtask] / plomtask / todos.py

diff --git a/plomtask/todos.py b/plomtask/todos.py
index 7faea73b74df9c4b5a8f68f6dceced09f27c9b67..8fa3b91407cbaef08e599faca708d7ffe9b5c8a0 100644 (file)
--- a/plomtask/todos.py
+++ b/plomtask/todos.py
@@ -15,16 +15,17 @@ class Todo:
                  is_done: bool, day: Day) -> None:
         self.id_ = id_
         self.process = process
-        self.is_done = is_done
+        self._is_done = is_done
         self.day = day
         self.children: list[Todo] = []
+        self.parents: list[Todo] = []
 
     @classmethod
     def from_table_row(cls, db_conn: DatabaseConnection, row: Row) -> Todo:
         """Make Todo from database row, write to DB cache."""
         todo = cls(id_=row[0],
                    process=Process.by_id(db_conn, row[1]),
-                   is_done=row[2],
+                   is_done=bool(row[2]),
                    day=Day.by_date(db_conn, row[3]))
         assert todo.id_ is not None
         db_conn.cached_todos[todo.id_] = todo
@@ -46,6 +47,9 @@ class Todo:
             for row in db_conn.exec('SELECT child FROM todo_children '
                                     'WHERE parent = ?', (id_,)):
                 todo.children += [cls.by_id(db_conn, row[0])]
+            for row in db_conn.exec('SELECT parent FROM todo_children '
+                                    'WHERE child = ?', (id_,)):
+                todo.parents += [cls.by_id(db_conn, row[0])]
         assert isinstance(todo, Todo)
         return todo
 
@@ -57,6 +61,25 @@ class Todo:
             todos += [cls.by_id(db_conn, row[0])]
         return todos
 
+    @property
+    def is_doable(self) -> bool:
+        """Decide whether .is_done can be set to True based on children's."""
+        for child in self.children:
+            if not child.is_done:
+                return False
+        return True
+
+    @property
+    def is_done(self) -> bool:
+        """Wrapper around self._is_done so we can control its setter."""
+        return self._is_done
+
+    @is_done.setter
+    def is_done(self, value: bool) -> None:
+        if value != self.is_done and not self.is_doable:
+            raise BadFormatException('cannot change doneness of undoable Todo')
+        self._is_done = value
+
     def add_child(self, child: Todo) -> None:
         """Add child to self.children, guard against recursion"""
         def walk_steps(node: Todo) -> None:
@@ -72,6 +95,7 @@ class Todo:
             raise BadFormatException('cannot adopt same child twice')
         walk_steps(child)
         self.children += [child]
+        child.parents += [self]
 
     def save(self, db_conn: DatabaseConnection) -> None:
         """Write self and children to DB and its cache."""