X-Git-Url: https://plomlompom.com/repos/foo.html?a=blobdiff_plain;f=tests%2Fconditions.py;h=2b522e65abbd4c1ef160f5bd1d9191b21e53d102;hb=84ff28d055b785e5f205f942c68ece72136e5af1;hp=37a97a5c91a4dcf6a25f26b2110b77e33c91519a;hpb=5afb47e3aaed921997d11abf88a81602700639f3;p=plomtask
diff --git a/tests/conditions.py b/tests/conditions.py
index 37a97a5..2b522e6 100644
--- a/tests/conditions.py
+++ b/tests/conditions.py
@@ -1,4 +1,5 @@
"""Test Conditions module."""
+from json import loads as json_loads
from tests.utils import TestCaseWithDB, TestCaseWithServer, TestCaseSansDB
from plomtask.conditions import Condition
from plomtask.processes import Process
@@ -16,17 +17,8 @@ class TestsSansDB(TestCaseSansDB):
class TestsWithDB(TestCaseWithDB):
"""Tests requiring DB, but not server setup."""
checked_class = Condition
-
- def test_Condition_saving_and_caching(self) -> None:
- """Test .save/.save_core."""
- kwargs = {'id_': 1, 'is_active': False}
- self.check_saving_and_caching(**kwargs)
- # check .id_ set if None, and versioned attributes too
- c = Condition(None)
- c.save(self.db_conn)
- self.assertEqual(c.id_, 2)
- self.check_saving_of_versioned('title', str)
- self.check_saving_of_versioned('description', str)
+ default_init_kwargs = {'is_active': False}
+ test_versioneds = {'title': str, 'description': str}
def test_Condition_from_table_row(self) -> None:
"""Test .from_table_row() properly reads in class from DB"""
@@ -53,13 +45,13 @@ class TestsWithDB(TestCaseWithDB):
def test_Condition_remove(self) -> None:
"""Test .remove() effects on DB and cache."""
self.check_remove()
- c = Condition(None)
proc = Process(None)
proc.save(self.db_conn)
todo = Todo(None, proc, False, '2024-01-01')
for depender in (proc, todo):
assert hasattr(depender, 'save')
assert hasattr(depender, 'set_conditions')
+ c = Condition(None)
c.save(self.db_conn)
depender.save(self.db_conn)
depender.set_conditions(self.db_conn, [c.id_], 'conditions')
@@ -76,18 +68,115 @@ class TestsWithServer(TestCaseWithServer):
def test_do_POST_condition(self) -> None:
"""Test POST /condition and its effect on the database."""
- form_data = {'title': 'foo', 'description': 'foo'}
- self.check_post(form_data, '/condition', 302, '/condition?id=1')
- self.assertEqual(1, len(Condition.all(self.db_conn)))
- form_data['delete'] = ''
- self.check_post(form_data, '/condition?id=', 404)
- self.check_post(form_data, '/condition?id=2', 404)
- self.check_post(form_data, '/condition?id=1', 302, '/conditions')
- self.assertEqual(0, len(Condition.all(self.db_conn)))
-
- def test_do_GET(self) -> None:
- """Test /condition and /conditions response codes."""
- form_data = {'title': 'foo', 'description': 'foo'}
+
+ def check(path: str, expected: dict[str, object]) -> None:
+ self.conn.request('GET', path)
+ response = self.conn.getresponse()
+ self.assertEqual(response.status, 200)
+ retrieved = json_loads(response.read().decode())
+ self.blank_history_keys_in(retrieved)
+ self.assertEqual(expected, retrieved)
+
+ # check empty POST fails
+ self.check_post({}, '/condition', 400)
+ # test valid POST's effect on â¦
+ post = {'title': 'foo', 'description': 'oof', 'is_active': False}
+ self.check_post(post, '/condition', 302, '/condition?id=1')
+ # ⦠single /condition
+ cond = {'id': 1, 'is_active': False,
+ 'title': {'parent_id': 1, 'history': {'[0]': 'foo'}},
+ 'description': {'parent_id': 1, 'history': {'[0]': 'oof'}}}
+ expected_single = {'is_new': False,
+ 'enabled_processes': [],
+ 'disabled_processes': [],
+ 'enabling_processes': [],
+ 'disabling_processes': [],
+ 'condition': cond}
+ check('/condition?id=1', expected_single)
+ # ⦠full /conditions
+ expected_all = {'conditions': [cond], 'sort_by': 'title', 'pattern': ''}
+ check('/conditions', expected_all)
+ # test effect of invalid POST to existing Condition on /condition
+ self.check_post({}, '/condition?id=1', 400)
+ check('/condition?id=1', expected_single)
+ # test deletion POST's effect on â¦
+ self.check_post({'delete': ''}, '/condition?id=1', 302, '/conditions')
+ cond['title']['history'] = {}
+ cond['description']['history'] = {}
+ check('/condition?id=1', expected_single)
+ # ⦠full /conditions
+ expected_all['conditions'] = []
+ check('/conditions', expected_all)
+
+ def test_do_GET_condition(self) -> None:
+ """Test GET /condition."""
+ form_data = {'title': 'foo', 'description': 'foo', 'is_active': False}
self.check_post(form_data, '/condition', 302, '/condition?id=1')
self.check_get_defaults('/condition')
- self.check_get('/conditions', 200)
+
+ def test_do_GET_conditions(self) -> None:
+ """Test GET /conditions."""
+
+ def check(params: str, expected_json: dict[str, object]) -> None:
+ self.conn.request('GET', f'/conditions{params}')
+ response = self.conn.getresponse()
+ self.assertEqual(response.status, 200)
+ retrieved_json = json_loads(response.read().decode())
+ self.blank_history_keys_in(retrieved_json)
+ self.assertEqual(expected_json, retrieved_json)
+
+ # test empty result on empty DB, default-settings on empty params
+ expected_json: dict[str, object] = {'conditions': [],
+ 'sort_by': 'title',
+ 'pattern': ''}
+ check('', expected_json)
+ # test on meaningless non-empty params (incl. entirely un-used key)
+ expected_json = {'conditions': [],
+ 'sort_by': 'title', # nonsense "foo" defaulting
+ 'pattern': 'bar'} # preserved despite zero effect
+ check('?sort_by=foo&pattern=bar&foo=x', expected_json)
+ # test non-empty result, automatic (positive) sorting by title
+ post_1 = {'title': 'foo', 'description': 'oof', 'is_active': False}
+ self.check_post(post_1, '/condition', 302, '/condition?id=1')
+ post_2 = {'title': 'bar', 'description': 'rab', 'is_active': False}
+ self.check_post(post_2, '/condition', 302, '/condition?id=2')
+ post_3 = {'title': 'baz', 'description': 'zab', 'is_active': True}
+ self.check_post(post_3, '/condition', 302, '/condition?id=3')
+ cond_1 = {'id': 1, 'is_active': False,
+ 'title': {'history': {'[0]': 'foo'},
+ 'parent_id': 1},
+ 'description': {'history': {'[0]': 'oof'},
+ 'parent_id': 1}}
+ cond_2 = {'id': 2, 'is_active': False,
+ 'title': {'history': {'[0]': 'bar'},
+ 'parent_id': 2},
+ 'description': {'history': {'[0]': 'rab'},
+ 'parent_id': 2}}
+ cond_3 = {'id': 3, 'is_active': True,
+ 'title': {'history': {'[0]': 'baz'},
+ 'parent_id': 3},
+ 'description': {'history': {'[0]': 'zab'},
+ 'parent_id': 3}}
+ cons = [cond_2, cond_3, cond_1]
+ expected_json = {'conditions': cons, 'sort_by': 'title', 'pattern': ''}
+ check('', expected_json)
+ # test other sortings
+ # (NB: by .is_active has two items of =False, their order currently
+ # is not explicitly made predictable, so mail fail until we do)
+ expected_json['conditions'] = [cond_1, cond_3, cond_2]
+ expected_json['sort_by'] = '-title'
+ check('?sort_by=-title', expected_json)
+ expected_json['conditions'] = [cond_1, cond_2, cond_3]
+ expected_json['sort_by'] = 'is_active'
+ check('?sort_by=is_active', expected_json)
+ expected_json['conditions'] = [cond_3, cond_1, cond_2]
+ expected_json['sort_by'] = '-is_active'
+ check('?sort_by=-is_active', expected_json)
+ # test pattern matching on title
+ expected_json = {'conditions': [cond_2, cond_3],
+ 'sort_by': 'title', 'pattern': 'ba'}
+ check('?pattern=ba', expected_json)
+ # test pattern matching on description
+ expected_json['conditions'] = [cond_1]
+ expected_json['pattern'] = 'oo'
+ check('?pattern=oo', expected_json)