From a69666dfbbc1c27f0b29f4a591a69630c470df87 Mon Sep 17 00:00:00 2001 From: Christian Heller Date: Tue, 30 Jul 2013 03:44:48 +0200 Subject: [PATCH] In shift_active_win() slightly improved formatting and solved a "why is this needed" comment question. --- src/windows.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/windows.c b/src/windows.c index 362e10a..7e0ba72 100644 --- a/src/windows.c +++ b/src/windows.c @@ -436,16 +436,18 @@ extern void shift_active_win(struct WinMeta * wmeta, char dir) wrap = 1; } - /* Suspend all visible windows. */ + /* Suspend all visible windows, remember their order in wins[]. */ uint16_t i, i_max; - for (w_p = wmeta->chain_start, i_max = 1; + for (w_p = wmeta->chain_start, i_max = 1; w_p != wmeta->chain_end; - w_p = w_p->next) + w_p = w_p->next) { i_max++; } struct Win ** wins = malloc(i_max * sizeof(struct Win *)); - for (i = 0, w_p = wmeta->chain_start; i < i_max; i++) + for (i = 0, w_p = wmeta->chain_start; + i < i_max; + i++) { w_p_next = w_p->next; suspend_win(wmeta, w_p); @@ -492,7 +494,7 @@ extern void shift_active_win(struct WinMeta * wmeta, char dir) } free(wins); - wmeta->active = w_shift; /* TODO: Is this necessary? If so, why? */ + wmeta->active = w_shift; /* Otherwise lastly appended win is active. */ } } -- 2.30.2