Added client commands config error check condition: third token longer than one char.

[plomrogue] / src / client / command_db.c

diff --git a/src/client/command_db.c b/src/client/command_db.c
index 7d35582dda258abb9472dcee87ce8bd7655d7e8d..19cd4064e09c7878d49d841ed1e86d30536ffc58 100644 (file)
--- a/src/client/command_db.c
+++ b/src/client/command_db.c
@@ -3,7 +3,7 @@
 #include "command_db.h"
 #include <stddef.h> /* NULL */
 #include <stdint.h> /* uint8_t, uint32_t */
-#include <stdio.h> /* FILE */
+#include <stdio.h> /* FILE, sprintf() */
 #include <stdlib.h> /* free() */
 #include <string.h> /* memcpy(), strlen(), strtok(), strcmp() */
 #include "../common/readwrite.h" /* try_fopen(), try_fclose(), try_fgets()
@@ -12,30 +12,52 @@
 #include "../common/rexit.h" /* for exit_err() */
 #include "../common/try_malloc.h" /* try_malloc() */
 #include "cleanup.h" /* set_cleanup_flag() */
+#include "misc.h" /* array_append() */
 #include "world.h" /* global world */
 
 
 
-/* Point "ch_ptr" to next strtok() string in "line" delimited by "delim".*/
-static void copy_tokenized_string(char * line, char ** ch_ptr, char * delim);
+/* Helpers to init_command_db(). */
+static uint8_t copy_tokenized_string(char * line, char ** ch_ptr, char * delim);
+static char * init_command_db_err(char * line_copy, uint8_t line_number);
 
 
-
-static void copy_tokenized_string(char * line, char ** ch_ptr, char * delim)
+static uint8_t copy_tokenized_string(char * line, char ** ch_ptr, char * delim)
 {
     char * f_name = "copy_tokenized_string()";
     char * dsc_ptr = strtok(line, delim);
+    if (!dsc_ptr)
+    {
+        return 1;
+    }
     * ch_ptr = try_malloc(strlen(dsc_ptr) + 1, f_name);
     memcpy(* ch_ptr, dsc_ptr, strlen(dsc_ptr) + 1);
+    return 0;
+}
+
+
+
+static char * init_command_db_err(char * line_copy, uint8_t line_number)
+{
+    char * f_name = "init_command_db_err";
+    char * err_start = "Failed reading command config file at ";
+    char * err_middle = " due to malformed line ";
+    line_copy[strlen(line_copy) - 1] = '\0';
+    char * err = try_malloc(strlen(err_start) + strlen(world.path_commands) +
+                            strlen(err_middle) + 3 + 2 + strlen(line_copy) + 1,
+                            f_name);
+    sprintf(err, "%s%s%s%d: %s", err_start, world.path_commands, err_middle,
+            line_number, line_copy);
+    return err;
 }
 
 
 
 extern struct Command * get_command(char * dsc_short)
 {
-    struct Command * cmd_ptr = world.cmd_db.cmds;
+    struct Command * cmd_ptr = world.commandDB.cmds;
     uint8_t i = 0;
-    while (i < world.cmd_db.n)
+    while (i < world.commandDB.n)
     {
         if (0 == strcmp(dsc_short, cmd_ptr->dsc_short))
         {
@@ -47,7 +69,7 @@ extern struct Command * get_command(char * dsc_short)
     char * err_start = "get_command_data() failed on request for: ";
     char err[strlen(err_start) + strlen(dsc_short) + 1];
     sprintf(err, "%s%s", err_start, dsc_short);
-    exit_err(i == world.cmd_db.n, err);
+    exit_err(i == world.commandDB.n, err);
     return cmd_ptr;
 }
 
@@ -56,12 +78,10 @@ extern struct Command * get_command(char * dsc_short)
 extern void init_command_db()
 {
     char * f_name = "init_command_db()";
-    char * path = "confclient/commands";
-    FILE * file = try_fopen(path, "r", f_name);
+    FILE * file = try_fopen(world.path_commands, "r", f_name);
     uint32_t lines;
     uint32_t linemax = textfile_sizes(file, &lines);
     char line[linemax + 1];
-    world.cmd_db.cmds = try_malloc(lines * sizeof(struct Command), f_name);
     uint8_t i = 0;
     char * delim = " ";
     while (try_fgets(line, linemax + 1, file, f_name))
@@ -70,20 +90,28 @@ extern void init_command_db()
         {
             break;
         }
-        copy_tokenized_string(line, &world.cmd_db.cmds[i].dsc_short, delim);
-        copy_tokenized_string(NULL, &world.cmd_db.cmds[i].server_msg, delim);
-        if (!strcmp("0", world.cmd_db.cmds[i].server_msg))
-        {
-            free(world.cmd_db.cmds[i].server_msg);
-            world.cmd_db.cmds[i].server_msg = NULL;
-        }
-        char * arg_string = strtok(NULL, delim);
-        world.cmd_db.cmds[i].arg = arg_string[0];
-        copy_tokenized_string(NULL, &world.cmd_db.cmds[i].dsc_long, "\n");
+        char line_copy[strlen(line) + 1];
+        sprintf(line_copy, "%s", line);
+        struct Command cmd;
+        char * arg_string;
+        exit_err((  copy_tokenized_string(line, &cmd.dsc_short, delim)
+                 || copy_tokenized_string(NULL, &cmd.server_msg, delim)
+                 || NULL == (arg_string = strtok(NULL, delim))
+                 || strlen(arg_string) > 1
+                 || copy_tokenized_string(NULL, &cmd.dsc_long, "\n")),
+                 init_command_db_err(line_copy, i + 1));
+        cmd.arg = arg_string[0];
+        if (!strcmp("0", cmd.server_msg))
+        {                          /* A .server_msg == NULL helps control.c's */
+            free(cmd.server_msg);  /* try_key() and try_server_command() to   */
+            cmd.server_msg = NULL; /* differentiate server commands from      */
+        }                          /* non-server commands.                    */
+        array_append(i, sizeof(struct Command), (void *) &cmd,
+                     (void **) &world.commandDB.cmds);
         i++;
     }
     try_fclose(file, f_name);
-    world.cmd_db.n = lines;
+    world.commandDB.n = i;
     set_cleanup_flag(CLEANUP_COMMANDS);
 }
 
@@ -92,12 +120,12 @@ extern void init_command_db()
 extern void free_command_db()
 {
     uint8_t i = 0;
-    while (i < world.cmd_db.n)
+    while (i < world.commandDB.n)
     {
-        free(world.cmd_db.cmds[i].dsc_short);
-        free(world.cmd_db.cmds[i].dsc_long);
-        free(world.cmd_db.cmds[i].server_msg);
+        free(world.commandDB.cmds[i].dsc_short);
+        free(world.commandDB.cmds[i].dsc_long);
+        free(world.commandDB.cmds[i].server_msg);
         i++;
     }
-    free(world.cmd_db.cmds);
+    free(world.commandDB.cmds);
 }